content/common/view_messages.h - Issue 601153002: [src/content] Apply automatic range checks to enum types across IPC .

Side by Side Diff: content/common/view_messages.h

Issue 601153002: [src/content] Apply automatic range checks to enum types across IPC . (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/common/navigation_gesture.h ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for page rendering.	5 // IPC messages for page rendering.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include "base/memory/shared_memory.h"	8 #include "base/memory/shared_memory.h"

9 #include "base/process/process.h"	9 #include "base/process/process.h"

10 #include "base/strings/string16.h"	10 #include "base/strings/string16.h"

(...skipping 61 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
72 #define IPC_MESSAGE_START ViewMsgStart	72 #define IPC_MESSAGE_START ViewMsgStart

73	73

74 IPC_ENUM_TRAITS(blink::WebMediaPlayerAction::Type)	74 IPC_ENUM_TRAITS(blink::WebMediaPlayerAction::Type)

75 IPC_ENUM_TRAITS(blink::WebPluginAction::Type)	75 IPC_ENUM_TRAITS(blink::WebPluginAction::Type)

76 IPC_ENUM_TRAITS(blink::WebPopupType)	76 IPC_ENUM_TRAITS(blink::WebPopupType)

77 IPC_ENUM_TRAITS(blink::WebTextDirection)	77 IPC_ENUM_TRAITS(blink::WebTextDirection)

78 IPC_ENUM_TRAITS(WindowContainerType)	78 IPC_ENUM_TRAITS(WindowContainerType)

79 IPC_ENUM_TRAITS(content::FaviconURL::IconType)	79 IPC_ENUM_TRAITS(content::FaviconURL::IconType)

80 IPC_ENUM_TRAITS(content::FileChooserParams::Mode)	80 IPC_ENUM_TRAITS(content::FileChooserParams::Mode)

81 IPC_ENUM_TRAITS(content::MenuItem::Type)	81 IPC_ENUM_TRAITS(content::MenuItem::Type)

82 IPC_ENUM_TRAITS(content::NavigationGesture)	82 IPC_ENUM_TRAITS_MAX_VALUE(content::NavigationGesture,

83 IPC_ENUM_TRAITS(content::PageZoom)	83 content::NavigationGestureLast)

	84 IPC_ENUM_TRAITS_MIN_MAX_VALUE(content::PageZoom, content::PageZoom::PAGE_ZOOM_OU T,

	85 content::PageZoom::PAGE_ZOOM_IN)
	Avi (use Gerrit) 2014/09/26 15:07:10 1) respect 80 column limit 2) alignment 1) respect 80 column limit 2) alignment
84 IPC_ENUM_TRAITS(gfx::FontRenderParams::Hinting)	86 IPC_ENUM_TRAITS(gfx::FontRenderParams::Hinting)

85 IPC_ENUM_TRAITS(gfx::FontRenderParams::SubpixelRendering)	87 IPC_ENUM_TRAITS(gfx::FontRenderParams::SubpixelRendering)

86 IPC_ENUM_TRAITS_MAX_VALUE(content::TapMultipleTargetsStrategy,	88 IPC_ENUM_TRAITS_MAX_VALUE(content::TapMultipleTargetsStrategy,

87 content::TAP_MULTIPLE_TARGETS_STRATEGY_MAX)	89 content::TAP_MULTIPLE_TARGETS_STRATEGY_MAX)

88 IPC_ENUM_TRAITS(content::StopFindAction)	90 IPC_ENUM_TRAITS(content::StopFindAction)

89 IPC_ENUM_TRAITS(content::ThreeDAPIType)	91 IPC_ENUM_TRAITS(content::ThreeDAPIType)

90 IPC_ENUM_TRAITS_MAX_VALUE(media::ChannelLayout, media::CHANNEL_LAYOUT_MAX - 1)	92 IPC_ENUM_TRAITS_MAX_VALUE(media::ChannelLayout, media::CHANNEL_LAYOUT_MAX - 1)

91 IPC_ENUM_TRAITS_MAX_VALUE(media::MediaLogEvent::Type,	93 IPC_ENUM_TRAITS_MAX_VALUE(media::MediaLogEvent::Type,

92 media::MediaLogEvent::TYPE_LAST)	94 media::MediaLogEvent::TYPE_LAST)

93 IPC_ENUM_TRAITS_MAX_VALUE(ui::TextInputMode, ui::TEXT_INPUT_MODE_MAX)	95 IPC_ENUM_TRAITS_MAX_VALUE(ui::TextInputMode, ui::TEXT_INPUT_MODE_MAX)

(...skipping 1536 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1630 // Since the browser keeps handles to the allocated transport DIBs, this	1632 // Since the browser keeps handles to the allocated transport DIBs, this

1631 // message is sent to tell the browser that it may release them when the	1633 // message is sent to tell the browser that it may release them when the

1632 // renderer is finished with them.	1634 // renderer is finished with them.

1633 IPC_MESSAGE_CONTROL1(ViewHostMsg_FreeTransportDIB,	1635 IPC_MESSAGE_CONTROL1(ViewHostMsg_FreeTransportDIB,

1634 TransportDIB::Id /* DIB id */)	1636 TransportDIB::Id /* DIB id */)

1635 #endif	1637 #endif

1636	1638

1637 // Adding a new message? Stick to the sort order above: first platform	1639 // Adding a new message? Stick to the sort order above: first platform

1638 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform	1640 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform

1639 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg.	1641 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg.

OLD	NEW