chrome/browser/resources/print_preview/settings/other_options_settings.html - Issue 601083004: Enable a11y audit for chrome://print and fix failing tests.

Unified Diff: chrome/browser/resources/print_preview/settings/other_options_settings.html

Issue 601083004: Enable a11y audit for chrome://print and fix failing tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attempt to fix flaky test found by trybots Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/settings/destination_settings.html ('k') | chrome/test/data/webui/print_preview.js » ('j') | chrome/test/data/webui/print_preview.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/other_options_settings.html

diff --git a/chrome/browser/resources/print_preview/settings/other_options_settings.html b/chrome/browser/resources/print_preview/settings/other_options_settings.html

index 4e5a4f83fd07444cbc87ddfac9da7187056e72a7..36f4a608b49dcb0566a88347a74f8c20de2058e1 100644

--- a/chrome/browser/resources/print_preview/settings/other_options_settings.html

+++ b/chrome/browser/resources/print_preview/settings/other_options_settings.html

@@ -4,35 +4,37 @@

</div>

- <div class="header-footer-container checkbox">

- <label aria-live="polite">

- <input class="header-footer-checkbox" type="checkbox">

- <span i18n-content="optionHeaderFooter"></span>

- </label>

- </div>

- <div class="fit-to-page-container checkbox">

- <label aria-live="polite">

- <input class="fit-to-page-checkbox" type="checkbox">

- <span i18n-content="optionFitToPage"></span>

- </label>

- </div>

- <div class="duplex-container checkbox">

- <label aria-live="polite">

- <input class="duplex-checkbox" type="checkbox">

- <span i18n-content="optionTwoSided"></span>

- </label>

- </div>

- <div class="css-background-container checkbox">

- <label aria-live="polite">

- <input class="css-background-checkbox" type="checkbox">

- <span i18n-content="optionBackgroundColorsAndImages"></span>

- </label>

- </div>

- <div class="selection-only-container checkbox">

- <label aria-live="polite">

- <input class="selection-only-checkbox" type="checkbox">

- <span i18n-content="optionSelectionOnly"></span>

- </label>

+ <div id="other-options-collapsible" class="collapsible">

hcarmona 2014/10/29 22:24:46 Creating this DIV and giving it an ID makes it eas

+ <div class="header-footer-container checkbox">

+ <label aria-live="polite">

+ <input class="header-footer-checkbox" type="checkbox">

+ <span i18n-content="optionHeaderFooter"></span>

+ </label>

+ </div>

+ <div class="fit-to-page-container checkbox">

+ <label aria-live="polite">

+ <input class="fit-to-page-checkbox" type="checkbox">

+ <span i18n-content="optionFitToPage"></span>

+ </label>

+ </div>

+ <div class="duplex-container checkbox">

+ <label aria-live="polite">

+ <input class="duplex-checkbox" type="checkbox">

+ <span i18n-content="optionTwoSided"></span>

+ </label>

+ </div>

+ <div class="css-background-container checkbox">

+ <label aria-live="polite">

+ <input class="css-background-checkbox" type="checkbox">

+ <span i18n-content="optionBackgroundColorsAndImages"></span>

+ </label>

+ </div>

+ <div class="selection-only-container checkbox">

+ <label aria-live="polite">

+ <input class="selection-only-checkbox" type="checkbox">

+ <span i18n-content="optionSelectionOnly"></span>

+ </label>

+ </div>

</div>