chrome/browser/resources/print_preview/settings/other_options_settings.html - Issue 601083004: Enable a11y audit for chrome://print and fix failing tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/print_preview/settings/other_options_settings.html

Issue 601083004: Enable a11y audit for chrome://print and fix failing tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attempt to fix flaky test found by trybots Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/settings/destination_settings.html ('k') | chrome/test/data/webui/print_preview.js » ('j') | chrome/test/data/webui/print_preview.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="other-options-settings"	1 <div id="other-options-settings"

2 class="other-options-settings two-column" hidden>	2 class="other-options-settings two-column" hidden>

3 <div class="left-column">	3 <div class="left-column">

4 <h1 i18n-content="optionsLabel"></h1>	4 <h1 i18n-content="optionsLabel"></h1>

5 </div>	5 </div>

6 <div class="right-column checkbox">	6 <div class="right-column checkbox">

7 <div class="header-footer-container checkbox">	7 <div id="other-options-collapsible" class="collapsible">
	hcarmona 2014/10/29 22:24:46 Creating this DIV and giving it an ID makes it eas Creating this DIV and giving it an ID makes it easier to test this UI. This div was previously created programatically in print_preview_animations.js. The code there already has a check to see if the div exists.
8 <label aria-live="polite">	8 <div class="header-footer-container checkbox">

9 <input class="header-footer-checkbox" type="checkbox">	9 <label aria-live="polite">

10 <span i18n-content="optionHeaderFooter"></span>	10 <input class="header-footer-checkbox" type="checkbox">

11 </label>	11 <span i18n-content="optionHeaderFooter"></span>

12 </div>	12 </label>

13 <div class="fit-to-page-container checkbox">	13 </div>

14 <label aria-live="polite">	14 <div class="fit-to-page-container checkbox">

15 <input class="fit-to-page-checkbox" type="checkbox">	15 <label aria-live="polite">

16 <span i18n-content="optionFitToPage"></span>	16 <input class="fit-to-page-checkbox" type="checkbox">

17 </label>	17 <span i18n-content="optionFitToPage"></span>

18 </div>	18 </label>

19 <div class="duplex-container checkbox">	19 </div>

20 <label aria-live="polite">	20 <div class="duplex-container checkbox">

21 <input class="duplex-checkbox" type="checkbox">	21 <label aria-live="polite">

22 <span i18n-content="optionTwoSided"></span>	22 <input class="duplex-checkbox" type="checkbox">

23 </label>	23 <span i18n-content="optionTwoSided"></span>

24 </div>	24 </label>

25 <div class="css-background-container checkbox">	25 </div>

26 <label aria-live="polite">	26 <div class="css-background-container checkbox">

27 <input class="css-background-checkbox" type="checkbox">	27 <label aria-live="polite">

28 <span i18n-content="optionBackgroundColorsAndImages"></span>	28 <input class="css-background-checkbox" type="checkbox">

29 </label>	29 <span i18n-content="optionBackgroundColorsAndImages"></span>

30 </div>	30 </label>

31 <div class="selection-only-container checkbox">	31 </div>

32 <label aria-live="polite">	32 <div class="selection-only-container checkbox">

33 <input class="selection-only-checkbox" type="checkbox">	33 <label aria-live="polite">

34 <span i18n-content="optionSelectionOnly"></span>	34 <input class="selection-only-checkbox" type="checkbox">

35 </label>	35 <span i18n-content="optionSelectionOnly"></span>

	36 </label>

	37 </div>

36 </div>	38 </div>

37 </div>	39 </div>

38 </div>	40 </div>

OLD	NEW