chrome/browser/resources/print_preview/search/destination_list_item.html - Issue 601083004: Enable a11y audit for chrome://print and fix failing tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/search/destination_list_item.html

Issue 601083004: Enable a11y audit for chrome://print and fix failing tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/previewarea/preview_area.js ('K') | « chrome/browser/resources/print_preview/previewarea/preview_area.js ('k') | chrome/browser/resources/print_preview/settings/destination_settings.html » ('j') | chrome/browser/resources/print_preview/settings/destination_settings.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/search/destination_list_item.html

diff --git a/chrome/browser/resources/print_preview/search/destination_list_item.html b/chrome/browser/resources/print_preview/search/destination_list_item.html

index 1c83492b506a1b98b701d5ed9d4de0e9fe040bac..020b70de73d0f706bd255998c2eab96cf4fb748a 100644

--- a/chrome/browser/resources/print_preview/search/destination_list_item.html

+++ b/chrome/browser/resources/print_preview/search/destination_list_item.html

@@ -1,6 +1,6 @@

- <img class="destination-list-item-icon">

+ <img class="destination-list-item-icon" alt="">

Aleksey Shlyapnikov 2014/10/21 01:58:36 Shouldn't we add role="presentation" here too?

hcarmona 2014/10/21 21:32:37 alt="" is equivalent to role="presentation". We co