chrome/browser/resources/print_preview/search/destination_list_item.html - Issue 601083004: Enable a11y audit for chrome://print and fix failing tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/print_preview/search/destination_list_item.html

Issue 601083004: Enable a11y audit for chrome://print and fix failing tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/print_preview/previewarea/preview_area.js ('K') | « chrome/browser/resources/print_preview/previewarea/preview_area.js ('k') | chrome/browser/resources/print_preview/settings/destination_settings.html » ('j') | chrome/browser/resources/print_preview/settings/destination_settings.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <li id="destination-list-item-template" class="destination-list-item" hidden>	1 <li id="destination-list-item-template" class="destination-list-item" hidden>

2 <span class="destination-list-item-content">	2 <span class="destination-list-item-content">

3 <img class="destination-list-item-icon">	3 <img class="destination-list-item-icon" alt="">
	Aleksey Shlyapnikov 2014/10/21 01:58:36 Shouldn't we add role="presentation" here too? Shouldn't we add role="presentation" here too? hcarmona 2014/10/21 21:32:37 alt="" is equivalent to role="presentation". We co Show quoted text On 2014/10/21 01:58:36, Aleksey Shlyapnikov wrote: > Shouldn't we add > > role="presentation" > > here too? alt="" is equivalent to role="presentation". We could use either one, but I chose alt="" because it exists in more places in the code.
4 <span class="destination-list-item-name"></span>	4 <span class="destination-list-item-name"></span>

5 <span class="offline-status" hidden></span>	5 <span class="offline-status" hidden></span>

6 <span class="register-promo" hidden>	6 <span class="register-promo" hidden>

7 <button i18n-content="registerPromoButtonText"	7 <button i18n-content="registerPromoButtonText"

8 class="register-promo-button">	8 class="register-promo-button">

9 </button>	9 </button>

10 </span>	10 </span>

11 </span>	11 </span>

12 </li>	12 </li>

OLD	NEW