Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

Issue 601073002: Move string descriptor getters from UsbDeviceHandle to UsbDevice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix function order. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/saved_devices_service_unittest.cc ('k') | chrome/browser/devtools/device/usb/android_usb_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/usb/android_usb_browsertest.cc
diff --git a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
index 2ae1c14fe8ff18858d6e397a9ad58accd69ac333..82067281140d7e0632774e2ff2c9dd7988f74854 100644
--- a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
+++ b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
@@ -144,20 +144,8 @@ class MockUsbDeviceHandle : public UsbDeviceHandle {
}
virtual bool ResetDevice() OVERRIDE { return true; }
-
- virtual bool GetManufacturer(base::string16* manufacturer) OVERRIDE {
- *manufacturer = base::UTF8ToUTF16(kDeviceManufacturer);
- return true;
- }
-
- virtual bool GetProduct(base::string16* product) OVERRIDE {
- *product = base::UTF8ToUTF16(kDeviceModel);
- return true;
- }
-
- virtual bool GetSerial(base::string16* serial) OVERRIDE {
- *serial = base::UTF8ToUTF16(kDeviceSerial);
- return true;
+ virtual bool GetStringDescriptor(uint8_t string_id, base::string16* content) {
+ return false;
}
// Async IO. Can be called on any thread.
@@ -379,6 +367,21 @@ class MockUsbDevice : public UsbDevice {
return config_desc_;
}
+ virtual bool GetManufacturer(base::string16* manufacturer) OVERRIDE {
+ *manufacturer = base::UTF8ToUTF16(kDeviceManufacturer);
+ return true;
+ }
+
+ virtual bool GetProduct(base::string16* product) OVERRIDE {
+ *product = base::UTF8ToUTF16(kDeviceModel);
+ return true;
+ }
+
+ virtual bool GetSerialNumber(base::string16* serial) OVERRIDE {
+ *serial = base::UTF8ToUTF16(kDeviceSerial);
+ return true;
+ }
+
virtual bool Close(scoped_refptr<UsbDeviceHandle> handle) OVERRIDE {
return true;
}
« no previous file with comments | « apps/saved_devices_service_unittest.cc ('k') | chrome/browser/devtools/device/usb/android_usb_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698