chrome/browser/devtools/device/usb/android_usb_device.cc - Issue 601073002: Move string descriptor getters from UsbDeviceHandle to UsbDevice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/usb/android_usb_device.cc

Issue 601073002: Move string descriptor getters from UsbDeviceHandle to UsbDevice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix function order. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/device/usb/android_usb_device.cc

diff --git a/chrome/browser/devtools/device/usb/android_usb_device.cc b/chrome/browser/devtools/device/usb/android_usb_device.cc

index 55b47c7bf3a734641bb3e2cec9e2c438d53f5848..0820fac3ab6a4cc0b03bbf073f412c5ea91e8167 100644

--- a/chrome/browser/devtools/device/usb/android_usb_device.cc

+++ b/chrome/browser/devtools/device/usb/android_usb_device.cc

@@ -96,7 +96,7 @@ scoped_refptr<AndroidUsbDevice> ClaimInterface(

return NULL;

base::string16 serial;

- if (!usb_handle->GetSerial(&serial) || serial.empty())

+ if (!usb_handle->GetDevice()->GetSerialNumber(&serial) || serial.empty())

return NULL;

return new AndroidUsbDevice(rsa_key,

« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_browsertest.cc ('k') | device/hid/hid_connection_unittest.cc » ('j') | no next file with comments »