Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 601043003: Speculative fix when translating blob data to a file path (Closed)

Created:
6 years, 2 months ago by qinmin
Modified:
6 years, 2 months ago
Reviewers:
xhwang
CC:
chromium-reviews, darin-cc_chromium.org, jam, avayvod+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Speculative fix when translating blob data to a file path Accoding to the stack on crbug.com/410602, BlobData can be null. However, I am not able to reproduce the bug with any test cases. So this is just a safe speculative fix. BUG=410602 Committed: https://crrev.com/d484d41c421e86d5d6f3d38b04c7a76accbf65f8 Cr-Commit-Position: refs/heads/master@{#297007}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add NOTREACHED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M content/browser/media/android/media_resource_getter_impl.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M media/base/android/media_player_bridge.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
qinmin
PTAL
6 years, 2 months ago (2014-09-25 22:01:52 UTC) #2
xhwang
lgtm % one suggestion https://codereview.chromium.org/601043003/diff/1/content/browser/media/android/media_resource_getter_impl.cc File content/browser/media/android/media_resource_getter_impl.cc (right): https://codereview.chromium.org/601043003/diff/1/content/browser/media/android/media_resource_getter_impl.cc#newcode56 content/browser/media/android/media_resource_getter_impl.cc:56: ReturnResultOnUIThread(callback, ""); If this shouldn't ...
6 years, 2 months ago (2014-09-25 23:11:11 UTC) #3
qinmin
https://codereview.chromium.org/601043003/diff/1/content/browser/media/android/media_resource_getter_impl.cc File content/browser/media/android/media_resource_getter_impl.cc (right): https://codereview.chromium.org/601043003/diff/1/content/browser/media/android/media_resource_getter_impl.cc#newcode56 content/browser/media/android/media_resource_getter_impl.cc:56: ReturnResultOnUIThread(callback, ""); On 2014/09/25 23:11:11, xhwang wrote: > If ...
6 years, 2 months ago (2014-09-26 18:48:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601043003/20001
6 years, 2 months ago (2014-09-26 18:49:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d2fba6b4e3e1cb0b66b1732da2ad6eda74acdae5
6 years, 2 months ago (2014-09-26 19:40:56 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 19:41:29 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d484d41c421e86d5d6f3d38b04c7a76accbf65f8
Cr-Commit-Position: refs/heads/master@{#297007}

Powered by Google App Engine
This is Rietveld 408576698