Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: media/base/android/media_player_bridge.cc

Issue 601043003: Speculative fix when translating blob data to a file path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add NOTREACHED Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/android/media_resource_getter_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_player_bridge.cc
diff --git a/media/base/android/media_player_bridge.cc b/media/base/android/media_player_bridge.cc
index bbb7a116c74d2e0d04b20c1447fa16bca5d18949..433a6a8d15a3c49b3d49a2c9fed3fb43c9672788 100644
--- a/media/base/android/media_player_bridge.cc
+++ b/media/base/android/media_player_bridge.cc
@@ -263,6 +263,11 @@ void MediaPlayerBridge::OnAuthCredentialsRetrieved(
}
void MediaPlayerBridge::ExtractMediaMetadata(const std::string& url) {
+ if (url.empty()) {
+ OnMediaError(MEDIA_ERROR_FORMAT);
+ return;
+ }
+
int fd;
int64 offset;
int64 size;
« no previous file with comments | « content/browser/media/android/media_resource_getter_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698