Issue 60103008: Revert "telemetry: Add GetRendererProcessFromTab to timeline model."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60103008: Revert "telemetry: Add GetRendererProcessFromTab to timeline model." (Closed)

Created:
7 years, 1 month ago by rmcilroy

Modified:
7 years, 1 month ago

Reviewers:

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, ernstm1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Revert "telemetry: Add GetRendererProcessFromTab to timeline model." This reverts commit r233417. The change was causing all smoothness tests to timeout on the perf waterfall. BUG=316178 TBR=tonyg@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233614

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -149 lines)			Patch
M	tools/perf/measurements/rasterize_and_record.py	View	3 chunks	+5 lines, -7 lines	0 comments	Download
M	tools/perf/metrics/rendering_stats.py	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	tools/perf/metrics/smoothness.py	View	3 chunks	+12 lines, -18 lines	0 comments	Download
M	tools/perf/metrics/smoothness_unittest.py	View	4 chunks	+11 lines, -13 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py	View	1 chunk	+0 lines, -30 lines	0 comments	Download
A +	tools/telemetry/telemetry/core/backends/chrome/trace_result.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py	View	5 chunks	+13 lines, -24 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py	View	3 chunks	+13 lines, -13 lines	0 comments	Download
M	tools/telemetry/telemetry/core/timeline/model.py	View	3 chunks	+0 lines, -15 lines	0 comments	Download
D	tools/telemetry/telemetry/core/trace_result.py	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/page_action.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/actions/pinch.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/actions/scroll.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/actions/wait.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/60103008/1

7 years, 1 month ago (2013-11-07 15:19:29 UTC) #1

Message was sent while issue was closed.

Change committed as 233614

Expand Messages | Collapse Messages