Issue 601015: Fix using of OmxInputBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 601015: Fix using of OmxInputBuffer (Closed)

Created:
10 years, 10 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com, scherkus (not reviewing), fbarchard, awong, Alpha Left Google

Visibility:
Public.

Description

Fix using of OmxInputBuffer OmxInputBuffer is now ref counted, but some code still try to delete it explicitly. This delete call is hidden in a template function so it was hard to find! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38571

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -8 lines)			Patch
	M	media/filters/omx_video_decode_engine.cc	View		1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages