Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: media/filters/omx_video_decode_engine.cc

Issue 601015: Fix using of OmxInputBuffer (Closed)
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/omx_video_decode_engine.cc
diff --git a/media/filters/omx_video_decode_engine.cc b/media/filters/omx_video_decode_engine.cc
index 1297af18a4fdc2ce43ad83252c5ad1d86c75a2e3..8092bd9b9667c7654c45ef660a5577d00c97eef2 100644
--- a/media/filters/omx_video_decode_engine.cc
+++ b/media/filters/omx_video_decode_engine.cc
@@ -104,14 +104,8 @@ void OmxVideoDecodeEngine::DecodeFrame(const Buffer& buffer,
OmxInputBuffer* input_buffer =
new OmxInputBuffer(data, buffer.GetDataSize());
- // Feed in the new buffer regardless.
- //
- // TODO(ajwong): This callback stuff is messy. Cleanup.
- CleanupCallback<OmxCodec::FeedCallback>* feed_done =
- new CleanupCallback<OmxCodec::FeedCallback>(
- NewCallback(this, &OmxVideoDecodeEngine::OnFeedDone));
- feed_done->DeleteWhenDone(input_buffer);
- omx_codec_->Feed(input_buffer, feed_done);
+ omx_codec_->Feed(input_buffer,
+ NewCallback(this, &OmxVideoDecodeEngine::OnFeedDone));
if (buffer.IsEndOfStream()) {
has_fed_on_eos_ = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698