Fix RenderProcessHostUnitTest.RendererProcessLimit to pass with --site-per-process

Fix RenderProcessHostUnitTest.RendererProcessLimit to pass with --site-per-process.

The --site-per-process mode does not allow renderer process reuse, so this test shouldn't run under that flag.

BUG=417518
Committed: https://crrev.com/b308a1ce85cf3206b10c9e896a2478608a80295b
Cr-Commit-Position: refs/heads/master@{#297029}

[alexmos, 2014-09-24 22:51:05]

alexmos@chromium.org changed reviewers:
+ sievers@chromium.org

[no sievers, 2014-09-25 00:46:19]

sievers@chromium.org changed reviewers:
+ ppi@chromium.org
- sievers@chromium.org

[no sievers, 2014-09-25 00:47:12]

+ppi

[ppi, 2014-09-25 08:36:59]

https://codereview.chromium.org/600993002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_process_host_unittest.cc (right):

https://codereview.chromium.org/600993002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_process_host_unittest.cc:38: if
(base::CommandLine::ForCurrentProcess()->HasSwitch(
The condition that disables the process reuse in RenderProcessHost is actually:

  if (command_line.HasSwitch(switches::kEnableStrictSiteIsolation) ||
      command_line.HasSwitch(switches::kSitePerProcess))

- would it make sense to match it here (i.e. disable for
kEnableStrictSiteIsolation as well) ?

[alexmos, 2014-09-25 17:41:15]

On 2014/09/25 08:36:59, ppi wrote:
>
https://codereview.chromium.org/600993002/diff/1/content/browser/renderer_hos...
> File content/browser/renderer_host/render_process_host_unittest.cc (right):
> 
>
https://codereview.chromium.org/600993002/diff/1/content/browser/renderer_hos...
> content/browser/renderer_host/render_process_host_unittest.cc:38: if
> (base::CommandLine::ForCurrentProcess()->HasSwitch(
> The condition that disables the process reuse in RenderProcessHost is
actually:
> 
>   if (command_line.HasSwitch(switches::kEnableStrictSiteIsolation) ||
>       command_line.HasSwitch(switches::kSitePerProcess))
> 
> - would it make sense to match it here (i.e. disable for
> kEnableStrictSiteIsolation as well) ?

Yes, I added this check here, and also for
SiteInstanceTest.ProcessSharingByType, which similarly exercises process reuse.

[alexmos, 2014-09-26 18:02:26]

alexmos@chromium.org changed reviewers:
+ creis@chromium.org

[alexmos, 2014-09-26 18:02:57]

Charlie, does this fix look good to you?

[ppi, 2014-09-26 18:06:49]

sorry for the delay, lgtm

[Charlie Reis, 2014-09-26 18:10:10]

LGTM too.

[alexmos, 2014-09-26 18:11:26]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2014-09-26 18:12:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600993002/20001

[commit-bot: I haz the power, 2014-09-26 18:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 18:25:53]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[alexmos, 2014-09-26 20:13:47]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2014-09-26 20:14:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600993002/40001

[commit-bot: I haz the power, 2014-09-26 21:03:01]

Committed patchset #3 (id:40001) as 46e6fb1f2bb4735731bab8f25ea5dac0fce8ff48

[commit-bot: I haz the power, 2014-09-26 21:03:48]

Patchset 3 (id:??) landed as
https://crrev.com/b308a1ce85cf3206b10c9e896a2478608a80295b
Cr-Commit-Position: refs/heads/master@{#297029}