Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2030)

Unified Diff: content/browser/site_instance_impl_unittest.cc

Issue 600993002: Fix RenderProcessHostUnitTest.RendererProcessLimit to pass with --site-per-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add CONTENT_EXPORT to kEnableStrictSiteIsolation Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_instance_impl_unittest.cc
diff --git a/content/browser/site_instance_impl_unittest.cc b/content/browser/site_instance_impl_unittest.cc
index 714f76a1db70aefeb2341af74d9f0759557d9497..e547e7bf1deb8f9a94c30049f55cdee8e7b16b38 100644
--- a/content/browser/site_instance_impl_unittest.cc
+++ b/content/browser/site_instance_impl_unittest.cc
@@ -568,10 +568,13 @@ static SiteInstanceImpl* CreateSiteInstance(BrowserContext* browser_context,
// Test to ensure that pages that require certain privileges are grouped
// in processes with similar pages.
TEST_F(SiteInstanceTest, ProcessSharingByType) {
- // This test shouldn't run with --site-per-process mode, since it doesn't
- // allow render process reuse, which this test explicitly exercises.
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kSitePerProcess))
+ // This test shouldn't run with --site-per-process or
+ // --enable-strict-site-isolation modes, since they don't allow render
+ // process reuse, which this test explicitly exercises.
+ const base::CommandLine& command_line =
+ *base::CommandLine::ForCurrentProcess();
+ if (command_line.HasSwitch(switches::kSitePerProcess) ||
+ command_line.HasSwitch(switches::kEnableStrictSiteIsolation))
return;
// On Android by default the number of renderer hosts is unlimited and process
« no previous file with comments | « content/browser/renderer_host/render_process_host_unittest.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698