[Checkstyle] Fix misc style issues in Java files.

[Checkstyle] Fix misc style issues in Java files.

BUG=318404
TBR=zea@chromium.org,mkosiba@chromium.org

Committed: https://crrev.com/d350ea5cedf5d3b139f7d88c3c66b3f5e36952c7
Cr-Commit-Position: refs/heads/master@{#296734}

[aurimas (slooooooooow), 2014-09-24 22:12:20]

aurimas@chromium.org changed reviewers:
+ newt@chromium.org

[aurimas (slooooooooow), 2014-09-24 22:12:21]

Hey Newton,

Please take a look at this massive change!

Aurimas

[aurimas (slooooooooow), 2014-09-24 23:12:54]

aurimas@chromium.org changed reviewers:
+ boliu@chromium.org, lambroslambrou@chromium.org, qinmin@chromium.org,
tedchoc@chromium.org

[aurimas (slooooooooow), 2014-09-24 23:12:54]

boliu@chromium.org: Please review changes in 
android_webview/

qinmin@chromium.org: Please review changes in 
media/

lambroslambrou@chromium.org: Please review changes in 
remoting/

tedchoc@chromium.org: Please review changes in 
chrome/ and content/

[aurimas (slooooooooow), 2014-09-24 23:14:01]

aurimas@chromium.org changed reviewers:
+ yfriedman@chromium.org

[aurimas (slooooooooow), 2014-09-24 23:14:02]

yfriedman: PTAL at changes in base/ and net/

[Lambros, 2014-09-24 23:54:38]

remoting/ lgtm, assuming it still compiles - see comments. You can verify this
by building the "remoting_apk" package.

Thanks for fixing up these style issues!

https://codereview.chromium.org/600983002/diff/20001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/TrackingInputHandler.java
(right):

https://codereview.chromium.org/600983002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/TrackingInputHandler.java:203:
float[] imageSize = {mRenderData.imageWidth, mRenderData.imageHeight};
Does this still compile if you remove the (float) casts here? IIRC, implicit
int->double works OK, but not sure about implicit int->float because it's lossy?

https://codereview.chromium.org/600983002/diff/20001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/TrackingInputHandler.java:305:
float[] delta = {deltaX, deltaY};
Ditto.

[Yaron, 2014-09-25 00:12:05]

https://chromiumcodereview.appspot.com/600983002/diff/20001/net/android/java/...
File net/android/java/src/org/chromium/net/ProxyChangeListener.java (right):

https://chromiumcodereview.appspot.com/600983002/diff/20001/net/android/java/...
net/android/java/src/org/chromium/net/ProxyChangeListener.java:104: final String
getHostName = "getHost";
this doesn't match item 5.2.7 of java style guide.

"Even when final and immutable, local variables are not considered to be
constants, and should not be styled as constants."

These are final and immutable so should be styled as contants

[Yaron, 2014-09-25 00:12:59]

On 2014/09/25 00:12:05, Yaron wrote:
>
https://chromiumcodereview.appspot.com/600983002/diff/20001/net/android/java/...
> File net/android/java/src/org/chromium/net/ProxyChangeListener.java (right):
> 
>
https://chromiumcodereview.appspot.com/600983002/diff/20001/net/android/java/...
> net/android/java/src/org/chromium/net/ProxyChangeListener.java:104: final
String
> getHostName = "getHost";
> this doesn't match item 5.2.7 of java style guide.
> 
> "Even when final and immutable, local variables are not considered to be
> constants, and should not be styled as constants."
> 
> These are final and immutable so should be styled as contants

err brain hurts from perf. nvm. lgtm

[stgao, 2014-09-25 00:13:59]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2014-09-25 00:14:00]

lgtm for chromedriver/

Many thanks for the cleanup!

[qinmin, 2014-09-25 00:21:59]

media/ lgtm

[aurimas (slooooooooow), 2014-09-25 00:27:47]

aurimas@chromium.org changed reviewers:
+ kolla@chromium.org, mkosiba@chromium.org, mmenke@chromium.org,
zea@chromium.org

[aurimas (slooooooooow), 2014-09-25 00:27:48]

mmenke@chromium.org: Please review changes in 
components/cronet

kolla@chromium.org: Please review changes in 
chromecast

zea@chromium.org: Please review changes in 
components/gcm_driver

mkosiba@chromium.org: Please review changes in
components/navigation_interception

[mmenke, 2014-09-25 00:29:33]

On 2014/09/25 00:27:48, aurimas wrote:
> mailto:mmenke@chromium.org: Please review changes in 
> components/cronet
> 
> mailto:kolla@chromium.org: Please review changes in 
> chromecast
> 
> mailto:zea@chromium.org: Please review changes in 
> components/gcm_driver
> 
> mailto:mkosiba@chromium.org: Please review changes in
> components/navigation_interception

components/cronet LGTM

[boliu, 2014-09-25 00:36:31]

android_webview lgtm

[gunsch, 2014-09-25 15:56:59]

gunsch@chromium.org changed reviewers:
+ gunsch@chromium.org
- kolla@chromium.org

[gunsch, 2014-09-25 15:57:10]

chromecast/ lgtm

[Ted C, 2014-09-25 17:13:08]

On 2014/09/25 15:57:10, gunsch wrote:
> chromecast/ lgtm

chrome, content - lgtm

[aurimas (slooooooooow), 2014-09-25 17:28:54]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:29:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600983002/20001

[commit-bot: I haz the power, 2014-09-25 17:35:52]

Committed patchset #2 (id:20001) as 84ba62e31fe95ac8e608bf1f89c3e140ea2654ce

[commit-bot: I haz the power, 2014-09-25 17:36:37]

Patchset 2 (id:??) landed as
https://crrev.com/d350ea5cedf5d3b139f7d88c3c66b3f5e36952c7
Cr-Commit-Position: refs/heads/master@{#296734}