Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 600983002: [Checkstyle] Fix misc style issues in Java files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/android/java/src/org/chromium/chromoting/TrackingInputHandler.java ('K') | « testing/android/junit/java/src/org/chromium/testing/local/GtestComputer.java ('k') | tools/android/findbugs_plugin/src/org/chromium/tools/findbugs/plugin/SynchronizedMethodDetector.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/checkstyle/chromium-style-5.0.xml
diff --git a/tools/android/checkstyle/chromium-style-5.0.xml b/tools/android/checkstyle/chromium-style-5.0.xml
index 938a7c8ead92f75aba3117e4407a5b5bfd4f50c7..bc40f87ac3d3ca9c39fd7772bdb852c7f2750b21 100644
--- a/tools/android/checkstyle/chromium-style-5.0.xml
+++ b/tools/android/checkstyle/chromium-style-5.0.xml
@@ -124,6 +124,7 @@
<property name="allowEmptyMethods" value="true"/>
</module>
<module name="WhitespaceAfter">
+ <property name="severity" value="error"/>
<property name="tokens" value="COMMA, SEMI, TYPECAST"/>
</module>
<module name="NoWhitespaceAfter">
@@ -142,7 +143,7 @@
<property name="severity" value="warning"/>
</module>
<module name="ParenPad">
- <property name="severity" value="warning"/>
+ <property name="severity" value="error"/>
</module>
<module name="ImportOrder">
<property name="severity" value="error"/>
@@ -159,7 +160,9 @@
<property name="throwsIndent" value="8"/>
</module>
</module>
- <module name="FileTabCharacter"/>
+ <module name="FileTabCharacter">
+ <property name="severity" value="error"/>
+ </module>
<module name="RegexpSingleline">
<property name="format" value="((//.*)|(\*.*))FIXME"/>
<property name="message" value="TODO is preferred to FIXME. e.g. &quot;TODO(johndoe):"/>
« remoting/android/java/src/org/chromium/chromoting/TrackingInputHandler.java ('K') | « testing/android/junit/java/src/org/chromium/testing/local/GtestComputer.java ('k') | tools/android/findbugs_plugin/src/org/chromium/tools/findbugs/plugin/SynchronizedMethodDetector.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698