Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 600843004: Setting AudioConfiguration and deleting DeviceCapabilities hacks (Closed)

Created:
6 years, 2 months ago by Charlie
Modified:
6 years, 2 months ago
Reviewers:
rkc, xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Setting AudioConfiguration and deleting DeviceCapabilities hacks Committed: https://crrev.com/a9c9ce4e42240749ce9a66179c6174e0235170c6 Cr-Commit-Position: refs/heads/master@{#297019}

Patch Set 1 #

Patch Set 2 : Correcting DeviceCapabilities #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -162 lines) Patch
M chrome/browser/extensions/api/copresence/copresence_api_unittest.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/copresence/copresence_translations.cc View 2 chunks +6 lines, -1 line 0 comments Download
M components/copresence/proto/data.proto View 1 chunk +0 lines, -4 lines 0 comments Download
M components/copresence/rpc/rpc_handler.cc View 1 2 chunks +9 lines, -93 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 2 chunks +0 lines, -62 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Charlie
Disclaimer: I haven't yet tested this against the server.
6 years, 2 months ago (2014-09-24 23:20:25 UTC) #2
Charlie
Ok, this is now working as verified in the Demo App.
6 years, 2 months ago (2014-09-25 17:34:50 UTC) #3
Charlie
Hey Xiyuan, Here are some updates to the copresence RPC handling. We're removing a bunch ...
6 years, 2 months ago (2014-09-26 17:16:46 UTC) #5
xiyuan
lgtm
6 years, 2 months ago (2014-09-26 17:29:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600843004/20001
6 years, 2 months ago (2014-09-26 18:06:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as cd40ca9e80dfd694581a48e8e9c9a4a49da2ab3d
6 years, 2 months ago (2014-09-26 20:19:21 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 20:20:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9c9ce4e42240749ce9a66179c6174e0235170c6
Cr-Commit-Position: refs/heads/master@{#297019}

Powered by Google App Engine
This is Rietveld 408576698