components/copresence/proto/data.proto - Issue 600843004: Setting AudioConfiguration and deleting DeviceCapabilities hacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/copresence/proto/data.proto

Issue 600843004: Setting AudioConfiguration and deleting DeviceCapabilities hacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Correcting DeviceCapabilities Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/copresence/copresence_translations.cc ('k') | components/copresence/rpc/rpc_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/copresence/proto/data.proto

diff --git a/components/copresence/proto/data.proto b/components/copresence/proto/data.proto

index b4bbb9da6491f9e3a205b862dbda0796c7e454bb..ef8e0ee7691fe018997e352ad79302ffc355de34 100644

--- a/components/copresence/proto/data.proto

+++ b/components/copresence/proto/data.proto

@@ -92,10 +92,6 @@ message PublishedMessage {

message TokenExchangeStrategy {

optional AudioConfiguration audio_configuration = 1;

optional BroadcastScanConfiguration broadcast_scan_configuration = 2;

- // TODO(rkc): Horrible hack. Get rid of this once the server tells us whether

- // or not to use audible for a given publish or subscribe.

- // http://b/16849245/

- optional bool use_audible = 99;

}

message SubscribedMessage {

message Debug {

« no previous file with comments | « chrome/browser/extensions/api/copresence/copresence_translations.cc ('k') | components/copresence/rpc/rpc_handler.cc » ('j') | no next file with comments »