Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 600833003: Conversion of any, NodeFilter and XPathNSResolver arguments is trivial (Closed)

Created:
6 years, 2 months ago by Jens Widell
Modified:
6 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Conversion of any, NodeFilter and XPathNSResolver arguments is trivial The 'any' type is converted to by constructing a ScriptValue object, which simply wraps the v8::Value. The 'NodeFilter' and 'XPathNSResolver' types are converted to by wrapping the v8::Value in custom objects, with "soft" type checks (null is returned on failure.) BUG=413257 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +10 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Jens Widell
PTAL
6 years, 2 months ago (2014-09-24 14:39:45 UTC) #1
Jens Widell
PTAL
6 years, 2 months ago (2014-09-24 14:40:09 UTC) #3
haraken
LGTM (Though we should get rid of the special-casing for NodeFilter and XPathNSResolver.)
6 years, 2 months ago (2014-09-24 14:43:26 UTC) #4
Jens Widell
On 2014/09/24 14:43:26, haraken wrote: > (Though we should get rid of the special-casing for ...
6 years, 2 months ago (2014-09-24 14:51:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600833003/1
6 years, 2 months ago (2014-09-24 14:53:55 UTC) #7
haraken
On 2014/09/24 14:51:58, Jens Widell wrote: > On 2014/09/24 14:43:26, haraken wrote: > > (Though ...
6 years, 2 months ago (2014-09-24 14:56:11 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 16:29:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182612

Powered by Google App Engine
This is Rietveld 408576698