Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 600833003: Conversion of any, NodeFilter and XPathNSResolver arguments is trivial (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp
index 2d482a1d94d759d5019cf28b91450750fdc7c461..14fd0d9bb38f77a498c602207979decec8b00ec7 100644
--- a/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -965,7 +965,7 @@ static void nodeFilterAttributeAttributeSetter(v8::Local<v8::Value> v8Value, con
{
v8::Handle<v8::Object> holder = info.Holder();
TestObject* impl = V8TestObject::toImpl(holder);
- TONATIVE_VOID(RefPtrWillBeRawPtr<NodeFilter>, cppValue, toNodeFilter(v8Value, info.Holder(), ScriptState::current(info.GetIsolate())));
+ RefPtrWillBeRawPtr<NodeFilter> cppValue = toNodeFilter(v8Value, info.Holder(), ScriptState::current(info.GetIsolate()));
impl->setNodeFilterAttribute(WTF::getPtr(cppValue));
}
@@ -5727,8 +5727,6 @@ static void voidMethodAnyArgMethod(const v8::FunctionCallbackInfo<v8::Value>& in
TestObject* impl = V8TestObject::toImpl(info.Holder());
ScriptValue anyArg;
{
- v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
anyArg = ScriptValue(ScriptState::current(info.GetIsolate()), info[0]);
}
impl->voidMethodAnyArg(anyArg);
@@ -6693,9 +6691,7 @@ static void voidMethodNodeFilterArgMethod(const v8::FunctionCallbackInfo<v8::Val
TestObject* impl = V8TestObject::toImpl(info.Holder());
RefPtrWillBeRawPtr<NodeFilter> nodeFilterArg;
{
- v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
- TONATIVE_VOID_INTERNAL(nodeFilterArg, toNodeFilter(info[0], info.Holder(), ScriptState::current(info.GetIsolate())));
+ nodeFilterArg = toNodeFilter(info[0], info.Holder(), ScriptState::current(info.GetIsolate()));
}
impl->voidMethodNodeFilterArg(nodeFilterArg.release());
}
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698