Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h

Issue 600693002: content: Cleanup GpuMemoryBufferImpl destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove scoped_refptr<> from sender param of DeletedGpuMemoryBuffer Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h
diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h b/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h
index 911a37e94bbd32cd98c8c19677206903059040f9..7debe8f99533d0d5a1cc936409b9b4dbdb069fcf 100644
--- a/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h
+++ b/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h
@@ -15,16 +15,17 @@ namespace content {
// Implementation of GPU memory buffer based on IO surfaces.
class GpuMemoryBufferImplIOSurface : public GpuMemoryBufferImpl {
public:
- GpuMemoryBufferImplIOSurface(const gfx::Size& size, unsigned internalformat);
- virtual ~GpuMemoryBufferImplIOSurface();
+ static scoped_ptr<GpuMemoryBufferImpl> CreateFromHandle(
+ const gfx::GpuMemoryBufferHandle& handle,
+ const gfx::Size& size,
+ unsigned internalformat,
+ const DestructionCallback& callback);
static bool IsFormatSupported(unsigned internalformat);
static bool IsUsageSupported(unsigned usage);
static bool IsConfigurationSupported(unsigned internalformat, unsigned usage);
static uint32 PixelFormat(unsigned internalformat);
- bool InitializeFromHandle(const gfx::GpuMemoryBufferHandle& handle);
-
// Overridden from gfx::GpuMemoryBuffer:
virtual void* Map() OVERRIDE;
virtual void Unmap() OVERRIDE;
@@ -32,6 +33,12 @@ class GpuMemoryBufferImplIOSurface : public GpuMemoryBufferImpl {
virtual gfx::GpuMemoryBufferHandle GetHandle() const OVERRIDE;
private:
+ GpuMemoryBufferImplIOSurface(const gfx::Size& size,
+ unsigned internalformat,
+ const DestructionCallback& callback,
+ IOSurfaceRef io_surface);
+ virtual ~GpuMemoryBufferImplIOSurface();
+
base::ScopedCFTypeRef<IOSurfaceRef> io_surface_;
DISALLOW_COPY_AND_ASSIGN(GpuMemoryBufferImplIOSurface);

Powered by Google App Engine
This is Rietveld 408576698