Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_android.cc

Issue 600693002: content: Cleanup GpuMemoryBufferImpl destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove scoped_refptr<> from sender param of DeletedGpuMemoryBuffer Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_memory_buffer_impl_android.cc
diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_android.cc b/content/common/gpu/client/gpu_memory_buffer_impl_android.cc
index 110a6559d3d0ae1de8e51909d951be86b0cccf68..b19efb4b7e8196f21719e0aa21b4fc2287edef91 100644
--- a/content/common/gpu/client/gpu_memory_buffer_impl_android.cc
+++ b/content/common/gpu/client/gpu_memory_buffer_impl_android.cc
@@ -35,7 +35,7 @@ void GpuMemoryBufferImpl::AllocateForChildProcess(
const AllocationCallback& callback) {
if (GpuMemoryBufferImplSharedMemory::IsConfigurationSupported(
size, internalformat, usage)) {
- GpuMemoryBufferImplSharedMemory::AllocateSharedMemoryForChildProcess(
+ GpuMemoryBufferImplSharedMemory::AllocateForChildProcess(
size, internalformat, child_process, callback);
return;
}
@@ -54,24 +54,15 @@ void GpuMemoryBufferImpl::DeletedByChildProcess(
scoped_ptr<GpuMemoryBufferImpl> GpuMemoryBufferImpl::CreateFromHandle(
const gfx::GpuMemoryBufferHandle& handle,
const gfx::Size& size,
- unsigned internalformat) {
+ unsigned internalformat,
+ const DestructionCallback& callback) {
switch (handle.type) {
- case gfx::SHARED_MEMORY_BUFFER: {
- scoped_ptr<GpuMemoryBufferImplSharedMemory> buffer(
- new GpuMemoryBufferImplSharedMemory(size, internalformat));
- if (!buffer->InitializeFromHandle(handle))
- return scoped_ptr<GpuMemoryBufferImpl>();
-
- return buffer.PassAs<GpuMemoryBufferImpl>();
- }
- case gfx::SURFACE_TEXTURE_BUFFER: {
- scoped_ptr<GpuMemoryBufferImplSurfaceTexture> buffer(
- new GpuMemoryBufferImplSurfaceTexture(size, internalformat));
- if (!buffer->InitializeFromHandle(handle))
- return scoped_ptr<GpuMemoryBufferImpl>();
-
- return buffer.PassAs<GpuMemoryBufferImpl>();
- }
+ case gfx::SHARED_MEMORY_BUFFER:
+ return GpuMemoryBufferImplSharedMemory::CreateFromHandle(
+ handle, size, internalformat, callback);
+ case gfx::SURFACE_TEXTURE_BUFFER:
+ return GpuMemoryBufferImplSurfaceTexture::CreateFromHandle(
+ handle, size, internalformat, callback);
default:
return scoped_ptr<GpuMemoryBufferImpl>();
}
« no previous file with comments | « content/common/gpu/client/gpu_memory_buffer_impl.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698