Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 600683002: Recursively load mojo packages (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Recursively load mojo packages Adds simple manifest file parsing to the package downloader, and recursively schedule loading dependencies of a package. R=ben@chromium.org Committed: https://crrev.com/852bc07ce1354a2fee8ff88b96b658ac930a4b69 Cr-Commit-Position: refs/heads/master@{#296471}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -14 lines) Patch
M base/json/json_reader.h View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/tools/package_manager/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/tools/package_manager/manifest.h View 1 chunk +46 lines, -0 lines 0 comments Download
A mojo/tools/package_manager/manifest.cc View 1 chunk +83 lines, -0 lines 0 comments Download
M mojo/tools/package_manager/package_manager_application.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M mojo/tools/package_manager/package_manager_application.cc View 1 4 chunks +40 lines, -5 lines 0 comments Download
M mojo/tools/package_manager/unpacker.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
6 years, 3 months ago (2014-09-24 16:56:59 UTC) #2
Ben Goodger (Google)
lgtm
6 years, 3 months ago (2014-09-24 17:12:35 UTC) #3
brettw
Committed patchset #2 (id:20001) to pending queue manually as 7cee7d1 (presubmit successful).
6 years, 3 months ago (2014-09-24 18:27:13 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 18:27:35 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/852bc07ce1354a2fee8ff88b96b658ac930a4b69
Cr-Commit-Position: refs/heads/master@{#296471}

Powered by Google App Engine
This is Rietveld 408576698