Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: mojo/tools/package_manager/manifest.cc

Issue 600683002: Recursively load mojo packages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/tools/package_manager/manifest.h ('k') | mojo/tools/package_manager/package_manager_application.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/package_manager/manifest.cc
diff --git a/mojo/tools/package_manager/manifest.cc b/mojo/tools/package_manager/manifest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5a0e346bbdf822d1f7f4aba05ec119740861cb9c
--- /dev/null
+++ b/mojo/tools/package_manager/manifest.cc
@@ -0,0 +1,83 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/tools/package_manager/manifest.h"
+
+#include "base/files/file_util.h"
+#include "base/json/json_reader.h"
+#include "base/values.h"
+#include "url/gurl.h"
+
+namespace mojo {
+
+Manifest::Manifest() {
+}
+
+Manifest::~Manifest() {
+}
+
+bool Manifest::Parse(const std::string& str, std::string* err_msg) {
+ int err_code = base::JSONReader::JSON_NO_ERROR;
+ scoped_ptr<base::Value> root(base::JSONReader::ReadAndReturnError(
+ str,
+ base::JSON_ALLOW_TRAILING_COMMAS,
+ &err_code, err_msg));
+ if (err_code != base::JSONReader::JSON_NO_ERROR)
+ return false;
+
+ const base::DictionaryValue* root_dict;
+ if (!root->GetAsDictionary(&root_dict)) {
+ *err_msg = "Manifest is not a dictionary.";
+ return false;
+ }
+
+ if (!PopulateDeps(root_dict, err_msg))
+ return false;
+
+ return true;
+}
+
+bool Manifest::ParseFromFile(const base::FilePath& file_name,
+ std::string* err_msg) {
+ std::string data;
+ if (!base::ReadFileToString(file_name, &data)) {
+ *err_msg = "Couldn't read manifest file " + file_name.AsUTF8Unsafe();
+ return false;
+ }
+ return Parse(data, err_msg);
+}
+
+bool Manifest::PopulateDeps(const base::DictionaryValue* root,
+ std::string* err_msg) {
+ const base::Value* deps_value;
+ if (!root->Get("deps", &deps_value))
+ return true; // No deps, that's OK.
+
+ const base::ListValue* deps;
+ if (!deps_value->GetAsList(&deps)) {
+ *err_msg = "Deps is not a list. Should be \"deps\": [ \"...\", \"...\" ]";
+ return false;
+ }
+
+ deps_.reserve(deps->GetSize());
+ for (size_t i = 0; i < deps->GetSize(); i++) {
+ std::string cur_dep;
+ if (!deps->GetString(i, &cur_dep)) {
+ *err_msg = "Dependency list item wasn't a string.";
+ return false;
+ }
+
+ GURL cur_url(cur_dep);
+ if (!cur_url.is_valid()) {
+ *err_msg = "Dependency entry isn't a valid URL: " + cur_dep;
+ return false;
+ }
+
+ deps_.push_back(cur_url);
+ }
+
+ return true;
+}
+
+} // namespace mojo
« no previous file with comments | « mojo/tools/package_manager/manifest.h ('k') | mojo/tools/package_manager/package_manager_application.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698