Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3387)

Unified Diff: chrome/browser/views/tabs/tab_renderer.cc

Issue 60066: Make the throbber throb sooner after you navigate. This fixes the new tab pag... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/tabs/tab_renderer.cc
===================================================================
--- chrome/browser/views/tabs/tab_renderer.cc (revision 13028)
+++ chrome/browser/views/tabs/tab_renderer.cc (working copy)
@@ -236,15 +236,20 @@
delete crash_animation_;
}
-void TabRenderer::UpdateData(TabContents* contents) {
+void TabRenderer::UpdateData(TabContents* contents, bool loading_only) {
DCHECK(contents);
- data_.favicon = contents->GetFavIcon();
- data_.title = UTF16ToWideHack(contents->GetTitle());
+ if (!loading_only) {
+ data_.title = UTF16ToWideHack(contents->GetTitle());
+ data_.off_the_record = contents->profile()->IsOffTheRecord();
+ data_.show_download_icon = contents->IsDownloadShelfVisible();
+ data_.crashed = contents->is_crashed();
+ data_.favicon = contents->GetFavIcon();
+ }
+
+ // Loading state also involves whether we show the favicon, since that's where
+ // we display the throbber.
data_.loading = contents->is_loading();
- data_.off_the_record = contents->profile()->IsOffTheRecord();
data_.show_icon = contents->ShouldDisplayFavIcon();
- data_.show_download_icon = contents->IsDownloadShelfVisible();
- data_.crashed = contents->is_crashed();
}
void TabRenderer::UpdateFromModel() {

Powered by Google App Engine
This is Rietveld 408576698