Make the throbber throb sooner after you navigate. This fixes the new tab pag...

chrome/browser/views/tabs/tab_renderer.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits>
 
 #include "chrome/browser/views/tabs/tab_renderer.h"
 
 #include "chrome/browser/browser.h"
 #include "chrome/browser/profile.h"
@@ skipping 218 matching lines @@
   hover_animation_->SetSlideDuration(kHoverDurationMs);
 
   pulse_animation_.reset(new ThrobAnimation(this));
   pulse_animation_->SetSlideDuration(kPulseDurationMs);
 }
 
 TabRenderer::~TabRenderer() {
   delete crash_animation_;
 }
 
-void TabRenderer::UpdateData(TabContents* contents) {
+void TabRenderer::UpdateData(TabContents* contents, bool loading_only) {
   DCHECK(contents);
-  data_.favicon = contents->GetFavIcon();
-  data_.title = UTF16ToWideHack(contents->GetTitle());
+  if (!loading_only) {
+    data_.title = UTF16ToWideHack(contents->GetTitle());
+    data_.off_the_record = contents->profile()->IsOffTheRecord();
+    data_.show_download_icon = contents->IsDownloadShelfVisible();
+    data_.crashed = contents->is_crashed();
+    data_.favicon = contents->GetFavIcon();
+  }
+
+  // Loading state also involves whether we show the favicon, since that's where
+  // we display the throbber.
   data_.loading = contents->is_loading();
-  data_.off_the_record = contents->profile()->IsOffTheRecord();
   data_.show_icon = contents->ShouldDisplayFavIcon();
-  data_.show_download_icon = contents->IsDownloadShelfVisible();
-  data_.crashed = contents->is_crashed();
 }
 
 void TabRenderer::UpdateFromModel() {
   // Force a layout, since the tab may have grown a favicon.
   Layout();
   SchedulePaint();
 
   if (data_.crashed) {
     if (!should_display_crashed_favicon_ && !IsPerformingCrashAnimation())
       StartCrashAnimation();
@@ skipping 436 matching lines @@
     tab_inactive_otr.image_l = rb.GetBitmapNamed(IDR_TAB_INACTIVE_LEFT_OTR);
     tab_inactive_otr.image_c = rb.GetBitmapNamed(IDR_TAB_INACTIVE_CENTER_OTR);
     tab_inactive_otr.image_r = rb.GetBitmapNamed(IDR_TAB_INACTIVE_RIGHT_OTR);
   }
 
   tab_inactive.l_width = tab_inactive.image_l->width();
   tab_inactive.r_width = tab_inactive.image_r->width();
   // tab_[hover,inactive_otr] width are not used and are initialized to 0
   // during static initialization.
 }