Issue 60066: Make the throbber throb sooner after you navigate. This fixes the new tab pag...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60066: Make the throbber throb sooner after you navigate. This fixes the new tab pag... (Closed)

Created:
11 years, 8 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the throbber throb sooner after you navigate. This fixes the new tab page, which would not start throbbing until the load committed. I think this was always broken, but switching the tab contents types covered it up. Now I have a flag that goes along with the tab updating that indicates if it's a load update or a full update. This is necessary to avoid updating the title to the page's URL until it does actually commit. BUG=9310 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13131

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -30 lines)			Patch
M	chrome/browser/browser.cc	View	4 chunks	+18 lines, -6 lines	1 comment	Download
M	chrome/browser/dom_ui/dom_ui_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_contents.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/tabs/tab_strip_model.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_unittest.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/views/tabs/dragged_tab_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/tabs/tab_renderer.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_renderer.cc	View	1 chunk	+11 lines, -6 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 8 months ago (2009-04-04 17:27:59 UTC) #2

LGTM.

BTW, OpenURLFromTab is crying out for a unit test.

http://codereview.chromium.org/60066/diff/1/3
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/60066/diff/1/3#newcode1660
Line 1660: ScheduleUIUpdate(source, TabContents::INVALIDATE_URL |
You might move this above the comment above since it's UpdateToolbar that does
the synchronous updating, or give this its own comment.

Expand Messages | Collapse Messages