Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 600523006: Don't create newtab for gaia login. (Closed)

Created:
6 years, 3 months ago by achuithb
Modified:
6 years, 3 months ago
Reviewers:
tbarzic, krishnargv
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't create newtab for gaia login. BUG=417248 TEST=login_GaiaLogin Committed: https://crrev.com/b58d114aa81875e999f33379dfb948ecf1535db1 Cr-Commit-Position: refs/heads/master@{#296470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
achuithb
Toni, please take a look.
6 years, 3 months ago (2014-09-24 12:55:51 UTC) #2
tbarzic
lgtm
6 years, 3 months ago (2014-09-24 16:55:20 UTC) #3
achuithb
On 2014/09/24 16:55:20, tbarzic wrote: > lgtm Ty
6 years, 3 months ago (2014-09-24 17:05:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600523006/1
6 years, 3 months ago (2014-09-24 17:06:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as f61dcb872241bb87869a92f40bb53272d86bffca
6 years, 3 months ago (2014-09-24 18:24:42 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 18:26:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b58d114aa81875e999f33379dfb948ecf1535db1
Cr-Commit-Position: refs/heads/master@{#296470}

Powered by Google App Engine
This is Rietveld 408576698