tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py - Issue 600523006: Don't create newtab for gaia login.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

Issue 600523006: Don't create newtab for gaia login. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

index bb431cea554e3c2631fd6a830583e61e63751582..1cae4a4e31618de14101c8688f0a7aa6d8ba0733 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

@@ -232,7 +232,7 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

# Workaround for crbug.com/374462 - the bug doesn't manifest in the guest

# session, which also starts with an open browser tab.

retries = 3

- while not self._is_guest:

+ while not self._is_guest and not self.browser_options.gaia_login:

try:

# Open a new window/tab.

tab = self.tab_list_backend.New(timeout=30)

« no previous file with comments | « no previous file | no next file » | no next file with comments »