Issue 600523002: Mojo: Remove MessagePipe::Attach().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 600523002: Mojo: Remove MessagePipe::Attach(). (Closed)

Created:
6 years, 3 months ago by viettrungluu

Modified:
6 years, 2 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@move_paused_message_queue-x-del_pmpe_attach

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Remove MessagePipe::Attach(). R=darin@chromium.org Committed: https://crrev.com/72c2a9ecc687a16f866956b890ee899f6efec724 Cr-Commit-Position: refs/heads/master@{#296793}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -40 lines)			Patch
M	mojo/system/channel.cc	View	1	1 chunk	+1 line, -26 lines	0 comments	Download
M	mojo/system/message_pipe.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/system/message_pipe.cc	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

(Dependent on https://codereview.chromium.org/587153003/.)

6 years, 3 months ago (2014-09-23 18:45:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600523002/40001

6 years, 2 months ago (2014-09-25 20:01:05 UTC) #4

commit-bot: I haz the power

Committed patchset #3 (id:40001) as 086eaa89e010eb765dcc5817aa14a2e56495f27e

6 years, 2 months ago (2014-09-25 21:16:56 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-25 21:17:34 UTC) #6

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/72c2a9ecc687a16f866956b890ee899f6efec724
Cr-Commit-Position: refs/heads/master@{#296793}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages