Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 587153003: Mojo: Move the paused message queue from ProxyMessagePipeEndpoint to ChannelEndpoint. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@del_pmpe_attach
Project:
chromium
Visibility:
Public.

Description

Mojo: Move the paused message queue from ProxyMessagePipeEndpoint to ChannelEndpoint. R=brettw@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/244b60328abd5ed39b6aafcef92955665da0c213

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M mojo/system/channel_endpoint.h View 3 chunks +10 lines, -0 lines 0 comments Download
M mojo/system/channel_endpoint.cc View 1 2 2 chunks +18 lines, -4 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 3 chunks +3 lines, -10 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 1 2 5 chunks +3 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/588193004/.)
6 years, 3 months ago (2014-09-22 19:32:56 UTC) #1
viettrungluu
-> brettw
6 years, 3 months ago (2014-09-24 19:15:00 UTC) #3
viettrungluu
ping
6 years, 2 months ago (2014-09-25 16:49:50 UTC) #4
brettw
lgtm
6 years, 2 months ago (2014-09-25 19:52:48 UTC) #5
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/244b60328abd5ed39b6aafcef92955665da0c213 Cr-Commit-Position: refs/heads/master@{#296772}
6 years, 2 months ago (2014-09-25 19:57:12 UTC) #6
viettrungluu
6 years, 2 months ago (2014-09-25 19:57:15 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 244b603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698