Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1964)

Unified Diff: Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py

Issue 600413002: Pass test-list as JSON to layout-test-server. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/harness/archived-results-dashboard.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py
diff --git a/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py b/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py
index 22b69be5d0889cabaa54ab2023c745683878010b..71c207f83c771d3c2dd664455931c6c41bb2abc3 100644
--- a/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py
+++ b/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py
@@ -48,14 +48,17 @@ class LayoutTestsHTTPServer(BaseHTTPServer.HTTPServer):
class LayoutTestsServerHTTPRequestHandler(ReflectionHandler):
def do_POST(self):
- # FIXME : Has to be json object
json_raw_data = self.rfile.read(int(self.headers.getheader('content-length')))
+ json_data = json.loads(json_raw_data)
+ test_list = ''
+ for each in json_data['tests']:
+ test_list += each + ' '
filesystem = FileSystem()
webkit_finder = WebKitFinder(filesystem)
script_dir = webkit_finder.path_from_webkit_base('Tools', 'Scripts')
executable_path = script_dir + "/run-webkit-tests"
cmd = "python " + executable_path + " --no-show-results "
- cmd += json_raw_data
+ cmd += test_list
process = subprocess.Popen(cmd, shell=True, cwd=script_dir, env=None, stdout=subprocess.PIPE, stderr=STDOUT)
self.send_response(200)
self.send_header('Access-Control-Allow-Origin', '*')
« no previous file with comments | « LayoutTests/fast/harness/archived-results-dashboard.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698