Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: LayoutTests/fast/harness/archived-results-dashboard.html

Issue 600413002: Pass test-list as JSON to layout-test-server. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/harness/archived-results-dashboard.html
diff --git a/LayoutTests/fast/harness/archived-results-dashboard.html b/LayoutTests/fast/harness/archived-results-dashboard.html
index af1e6b4582594cff19da6aba2be868e184e677ee..e8a4455b26ca46d43b5d08f4bb9df633f8354bf0 100644
--- a/LayoutTests/fast/harness/archived-results-dashboard.html
+++ b/LayoutTests/fast/harness/archived-results-dashboard.html
@@ -122,13 +122,14 @@ function getTests()
{
var table = document.getElementById('results-table');
var testCount = table.rows.length;
- //FIXME : CONVERT TO JSON
- var tests_list = '';
+ var tests_list = {
+ tests : []
+ };
for(var i = 1; i < testCount; i++) {
var selected = table.rows[i].cells[0].getElementsByTagName("input")[0];
if(selected.checked) {
var test = table.rows[i].cells[1].innerHTML;
- tests_list += test + ' ' ;
+ tests_list.tests.push(test);
}
}
return tests_list;
@@ -152,7 +153,7 @@ function rerun()
if(xmlhttp.readyState > 0)
document.body.innerHTML = xmlhttp.responseText;
}
- xmlhttp.send(String(getTests()));
+ xmlhttp.send(JSON.stringify(getTests()));
}
}
function checkalltests()
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698