Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 600303002: [ServiceWorker] Don't send fetch event to the ServiceWorker if the page is not controled by it yet. (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, dmurph
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Don't send fetch event to the ServiceWorker if the page is not controled by it yet. Currenty active_version() is used to check whether the page is under the control of the ServiceWorker. But this is not correct. We have to use controlling_version(). BUG=417351 TEST=http/tests/serviceworker/uncontrolled-page.html in https://codereview.chromium.org/600843003 Committed: https://crrev.com/bb0a225bc67c750c0c53c5ce99be9f505954409e Cr-Commit-Position: refs/heads/master@{#296643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
horo
nhiroki@ Could you please review this?
6 years, 2 months ago (2014-09-25 02:05:29 UTC) #2
nhiroki
Good catch! LGTM nit: can you update the TEST= line? (for example, "TEST=https://codereview.chromium.org/600843003")
6 years, 2 months ago (2014-09-25 03:31:31 UTC) #3
horo
On 2014/09/25 03:31:31, nhiroki wrote: > Good catch! LGTM > > nit: can you update ...
6 years, 2 months ago (2014-09-25 03:39:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600303002/1
6 years, 2 months ago (2014-09-25 03:51:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 30bd64cc223cccf1293afca319898fb841f69ee5
6 years, 2 months ago (2014-09-25 04:24:52 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 04:25:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb0a225bc67c750c0c53c5ce99be9f505954409e
Cr-Commit-Position: refs/heads/master@{#296643}

Powered by Google App Engine
This is Rietveld 408576698