Issue 600843003: Test of uncontrolled page doing a fetch, which currently hits the sw.

Issue 600843003: Test of uncontrolled page doing a fetch, which currently hits the sw. (Closed)

Created:
6 years, 3 months ago by dmurph

Modified:
6 years, 2 months ago

Reviewers:
horo

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Test of uncontrolled page doing a fetch, which currently hits the sw. This fails the test, as it should. BUG=417351 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183015

Patch Set 3 : Removed unneeded file. #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	A	LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	A	LayoutTests/http/tests/serviceworker/uncontrolled-page.html	View	1	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 12 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

horo

Thank you for creating this test. https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js File LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js (right): https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js#newcode1 LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:1: importScripts('worker-test-harness.js'); importScripts('worker-test-harness.js'); this.addEventListener('fetch', ...

6 years, 2 months ago (2014-09-25 09:49:00 UTC) #2

Thank you for creating this test.

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js
(right):

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:1:
importScripts('worker-test-harness.js');
importScripts('worker-test-harness.js');

this.addEventListener('fetch', function(event) {
    event.respondWith(new Response('ERROR'));
  });

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:4:
event.respondWith(new Response("ERROR"));
+2 indent space

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:4:
event.respondWith(new Response("ERROR"));
use single-quotes

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:5: });
+2 indent space

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/uncontrolled-page.html (right):

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/uncontrolled-page.html:1: <!DOCTYPE html>
indent fix


<!DOCTYPE html>
<title>Service Worker: Registration</title>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
<script src="resources/test-helpers.js"></script>
<script>
function fetch_url(url) {
  return new Promise(function(resolve, reject) {
      var request = new XMLHttpRequest();
      request.addEventListener('load', function(event) {
          if (request.status == 200)
            resolve(request.response);
          else
            reject(Error(request.statusText));
        });
      request.open('GET', url);
      request.send();
    });
}
var worker = 'resources/fail-on-fetch-worker.js';

async_test(function(t) {
    var scope = '/';
    service_worker_unregister_and_register(t, worker, scope)
      .then(function(reg) { return wait_for_activated(t, reg, scope); })
      .then(function() {
          return fetch_url('/serviceworker/resources/simple.json');
        })
      .then(function(json) {
          assert_equals(json, '{ "a" : 1, "b" : 2 }\n');
          service_worker_unregister_and_done(t, scope);
        })
      .catch(t.step_func(function(reason) {
          assert_unreached(reason.message);
        }));
  }, 'Fetch events should not go through uncontrolled page.');
</script>

dmurph

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js File LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js (right): https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js#newcode1 LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:1: importScripts('worker-test-harness.js'); On 2014/09/25 09:49:00, horo wrote: > importScripts('worker-test-harness.js'); > ...

6 years, 2 months ago (2014-09-26 17:42:03 UTC) #3

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js
(right):

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:1:
importScripts('worker-test-harness.js');
On 2014/09/25 09:49:00, horo wrote:
> importScripts('worker-test-harness.js');
> 
> this.addEventListener('fetch', function(event) {
>     event.respondWith(new Response('ERROR'));
>   });

Done.

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:4:
event.respondWith(new Response("ERROR"));
On 2014/09/25 09:49:00, horo wrote:
> +2 indent space

Done.

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:4:
event.respondWith(new Response("ERROR"));
On 2014/09/25 09:49:00, horo wrote:
> use single-quotes

Done.

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js:5: });
On 2014/09/25 09:49:00, horo wrote:
> +2 indent space

Done.

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/uncontrolled-page.html (right):

https://codereview.chromium.org/600843003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/uncontrolled-page.html:1: <!DOCTYPE html>
On 2014/09/25 09:49:00, horo wrote:
> indent fix
> 
> 
> <!DOCTYPE html>
> <title>Service Worker: Registration</title>
> <script src="../resources/testharness.js"></script>
> <script src="../resources/testharnessreport.js"></script>
> <script src="resources/test-helpers.js"></script>
> <script>
> function fetch_url(url) {
>   return new Promise(function(resolve, reject) {
>       var request = new XMLHttpRequest();
>       request.addEventListener('load', function(event) {
>           if (request.status == 200)
>             resolve(request.response);
>           else
>             reject(Error(request.statusText));
>         });
>       request.open('GET', url);
>       request.send();
>     });
> }
> var worker = 'resources/fail-on-fetch-worker.js';
> 
> async_test(function(t) {
>     var scope = '/';
>     service_worker_unregister_and_register(t, worker, scope)
>       .then(function(reg) { return wait_for_activated(t, reg, scope); })
>       .then(function() {
>           return fetch_url('/serviceworker/resources/simple.json');
>         })
>       .then(function(json) {
>           assert_equals(json, '{ "a" : 1, "b" : 2 }\n');
>           service_worker_unregister_and_done(t, scope);
>         })
>       .catch(t.step_func(function(reason) {
>           assert_unreached(reason.message);
>         }));
>   }, 'Fetch events should not go through uncontrolled page.');
> </script>

Done.

horo

lgtm with nit. https://codereview.chromium.org/600843003/diff/20001/LayoutTests/http/tests/serviceworker/resources/request-worker.js File LayoutTests/http/tests/serviceworker/resources/request-worker.js (right): https://codereview.chromium.org/600843003/diff/20001/LayoutTests/http/tests/serviceworker/resources/request-worker.js#newcode347 LayoutTests/http/tests/serviceworker/resources/request-worker.js:347: var original_request = request; nit: This ...

6 years, 2 months ago (2014-09-29 04:07:41 UTC) #4

dmurph

https://codereview.chromium.org/600843003/diff/20001/LayoutTests/http/tests/serviceworker/resources/request-worker.js File LayoutTests/http/tests/serviceworker/resources/request-worker.js (right): https://codereview.chromium.org/600843003/diff/20001/LayoutTests/http/tests/serviceworker/resources/request-worker.js#newcode347 LayoutTests/http/tests/serviceworker/resources/request-worker.js:347: var original_request = request; On 2014/09/29 04:07:40, horo wrote: ...

6 years, 2 months ago (2014-09-29 22:53:24 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600843003/40001

6 years, 2 months ago (2014-09-29 22:54:35 UTC) #7

commit-bot: I haz the power

Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/29376)

6 years, 2 months ago (2014-09-30 01:06:57 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600843003/40001

6 years, 2 months ago (2014-10-01 00:43:53 UTC) #11

commit-bot: I haz the power

6 years, 2 months ago (2014-10-01 01:20:40 UTC) #12

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as 183015

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages