[GCM] Investigatory CHECKs for crash in parsing stream

[GCM] Investigatory CHECKs for crash in parsing stream

The various places where size_t and uint64 were being used have been converted
to int, so that we can better check to make sure they're non-negative (they're
actually consumed as ints by the protobuf parsing code). Various CHECKS have
therefore been added to verify assumptions.

BUG=409985
Committed: https://crrev.com/f8bef1c6b2f9b3585af2dc619246359bba8cfbd1
Cr-Commit-Position: refs/heads/master@{#296741}

[Nicolas Zea, 2014-09-24 23:34:15]

zea@chromium.org changed reviewers:
+ fgorski@chromium.org

[Nicolas Zea, 2014-09-24 23:34:15]

PTAL

[fgorski, 2014-09-25 17:29:56]

lgtm.

Could you document the expectation for the CHECKs? I mean they will crash the
retail build and not only debug, right? That is assuming anything goes wrong.

[Nicolas Zea, 2014-09-25 17:32:25]

On 2014/09/25 17:29:56, fgorski wrote:
> lgtm.
> 
> Could you document the expectation for the CHECKs? I mean they will crash the
> retail build and not only debug, right? That is assuming anything goes wrong.

What do you mean? Crashing builds is the expectation for all CHECKs. Or are you
referring to documenting why the conditions they're verifying should be true?

[fgorski, 2014-09-25 17:35:00]

On 2014/09/25 17:32:25, Nicolas Zea wrote:
> On 2014/09/25 17:29:56, fgorski wrote:
> > lgtm.
> > 
> > Could you document the expectation for the CHECKs? I mean they will crash
the
> > retail build and not only debug, right? That is assuming anything goes
wrong.
> 
> What do you mean? Crashing builds is the expectation for all CHECKs. Or are
you
> referring to documenting why the conditions they're verifying should be true?

Took a second look, the TODOs seem to be doing what I was thinking about.
Go ahead and check in

[Nicolas Zea, 2014-09-25 17:45:19]

The CQ bit was checked by zea@chromium.org

[Nicolas Zea, 2014-09-25 17:45:19]

The CQ bit was unchecked by zea@chromium.org

[Nicolas Zea, 2014-09-25 17:45:20]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:46:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600223003/1

[commit-bot: I haz the power, 2014-09-25 17:58:40]

Committed patchset #1 (id:1) as 33f6c51a4c5fbc8a058fe3ffe7066502b480cf92

[commit-bot: I haz the power, 2014-09-25 17:59:27]

Patchset 1 (id:??) landed as
https://crrev.com/f8bef1c6b2f9b3585af2dc619246359bba8cfbd1
Cr-Commit-Position: refs/heads/master@{#296741}