google_apis/gcm/base/socket_stream.h - Issue 600223003: [GCM] Investigatory CHECKs for crash in parsing stream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/base/socket_stream.h

Issue 600223003: [GCM] Investigatory CHECKs for crash in parsing stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/base/socket_stream.h

diff --git a/google_apis/gcm/base/socket_stream.h b/google_apis/gcm/base/socket_stream.h

index a45842016f6ce4c68f60d44c15d2fe15c6d725dd..61aa1fefd5f3c421e8f62a3a3774b728c9ca4879 100644

--- a/google_apis/gcm/base/socket_stream.h

+++ b/google_apis/gcm/base/socket_stream.h

@@ -72,7 +72,7 @@ class GCM_EXPORT SocketInputStream

virtual int64 ByteCount() const OVERRIDE;

// The remaining amount of valid data available to be read.

- size_t UnreadByteCount() const;

+ int UnreadByteCount() const;

// Reads from the socket, appending a max of |byte_limit| bytes onto the read

// buffer. net::ERR_IO_PENDING is returned if the refresh can't complete

« no previous file with comments | « no previous file | google_apis/gcm/base/socket_stream.cc » ('j') | no next file with comments »