Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 600223002: Minimal feature collector for select selectors. (Closed)

Created:
6 years, 3 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@select-features-20140924
Project:
blink
Visibility:
Public.

Description

Minimal feature collector for select selectors. Use a feature collector method that collects necessary features for select attribute selectors. These selectors can only have element, id, class, attribute and :not() according to the spec, and no combinators. Blink also supports pseudo classes for UA shadow DOM. A motivation here is to be able to collapse RuleFeatureSet::collectFeaturesFromSelector into the same loop as updateInvalidationSets now that invalidation sets are always in use. R=chrishtr@chromium.org,esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M Source/core/css/RuleFeature.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/shadow/SelectRuleFeatureSet.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/shadow/SelectRuleFeatureSet.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
Patch on top of https://codereview.chromium.org/598093005
6 years, 3 months ago (2014-09-24 23:16:00 UTC) #1
esprehn
lgtm
6 years, 2 months ago (2014-09-26 04:03:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600223002/1
6 years, 2 months ago (2014-09-26 10:02:03 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 11:07:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182755

Powered by Google App Engine
This is Rietveld 408576698