Issue 598093005: Simplify SelectRuleFeatureSet class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 598093005: Simplify SelectRuleFeatureSet class. (Closed)

Created:
6 years, 3 months ago by rune

Modified:
6 years, 2 months ago

Reviewers:
chrishtr, esprehn

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Simplify SelectRuleFeatureSet class. Subclass SelectRuleFeatureSet from RuleFeatureSet instead of having it as a member. Also make use of the parsePseudo method to simplify the Internals helper. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182746

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -80 lines)			Patch
M	Source/core/dom/shadow/SelectRuleFeatureSet.h	View		1 chunk	+1 line, -46 lines	0 comments	Download
M	Source/core/dom/shadow/SelectRuleFeatureSet.cpp	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	1	1 chunk	+1 line, -19 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598093005/20001

6 years, 2 months ago (2014-09-26 07:47:45 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 09:30:53 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 182746

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages