Instrumenting OnExtensionAddListener observer invocation

base/profiler/scoped_profile.h

Index: base/profiler/scoped_profile.h
diff --git a/base/profiler/scoped_profile.h b/base/profiler/scoped_profile.h
index c435a1dea1cd40513c3ec662c33e366f7f9deaf6..6f55cd8718eba7cd2c1ff93460c007fcb28e9b0c 100644
--- a/base/profiler/scoped_profile.h
+++ b/base/profiler/scoped_profile.h
@@ -44,6 +44,12 @@
     ::tracked_objects::ScopedProfile some_tracking_variable_name(              \
         FROM_HERE_WITH_EXPLICIT_FUNCTION(#dispatch_function_name))
 
+// Profiled region for developer and official builds. It allows developers to do
+// profiling of their code, and see results on their about:profiler page and in
+// Google-internal server-side tools.
+#define TRACK_RUN_IN_THIS_SCOPED_REGION(scope_name) \
+    TRACK_RUN_IN_IPC_HANDLER(scope_name)

[Ilya Sherman, 2014/09/24 23:38:01]

It looks like all of the macros in this file could be replaced with this:

#define PASTE_LINE_NUMBER_ON_NAME(name, line) name##line

#define LINE_BASED_VARIABLE_NAME_FOR_PROFILING \
    PASTE_LINE_NUMBER_ON_NAME(some_profiler_variable_, __LINE__)

// Defines the containing scope as a profiled region. This allows developers to
// profile their code and see results on their about:profiler page, as well as
// on the UMA dashboard.
#define TRACK_RUN_IN_THIS_SCOPED_REGION(scope_name) \
    ::tracked_objects::ScopedProfile  LINE_BASED_VARIABLE_NAME_FOR_PROFILING(
        FROM_HERE_WITH_EXPLICIT_FUNCTION(#scope_name))


That is, we can delete TRACK_RUN_IN_THIS_SCOPED_REGION_FOR_DEVELOPER_BUILDS,
since it's unused; and we can rename TRACK_RUN_IN_IPC_HANDLER to the more
general name TRACK_RUN_IN_THIS_SCOPED_REGION.

When renaming the macro, it looks like the #include in
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/proxy/dispat...
can just be removed.

[vadimt, 2014/09/25 00:21:21]

Done.

+
 
 namespace tracked_objects {
 class Births;