Instrumenting OnExtensionAddListener observer invocation

base/profiler/scoped_profile.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 #ifndef BASE_PROFILER_SCOPED_PROFILE_H_
 #define BASE_PROFILER_SCOPED_PROFILE_H_
 
 //------------------------------------------------------------------------------
 // ScopedProfile provides basic helper functions for profiling a short
@@ skipping 26 matching lines @@
 
 #define PASTE_LINE_NUMBER_ON_NAME(name, line) name##line
 
 #define LINE_BASED_VARIABLE_NAME_FOR_PROFILING                                 \
     PASTE_LINE_NUMBER_ON_NAME(some_profiler_variable_, __LINE__)
 
 #define TRACK_RUN_IN_IPC_HANDLER(dispatch_function_name)                       \
     ::tracked_objects::ScopedProfile some_tracking_variable_name(              \
         FROM_HERE_WITH_EXPLICIT_FUNCTION(#dispatch_function_name))
 
+// Profiled region for developer and official builds. It allows developers to do
+// profiling of their code, and see results on their about:profiler page and in
+// Google-internal server-side tools.
+#define TRACK_RUN_IN_THIS_SCOPED_REGION(scope_name) \
+    TRACK_RUN_IN_IPC_HANDLER(scope_name)

[Ilya Sherman, 2014/09/24 23:38:01]

It looks like all of the macros in this file could be replaced with this:

#define PASTE_LINE_NUMBER_ON_NAME(name, line) name##line

#define LINE_BASED_VARIABLE_NAME_FOR_PROFILING \
    PASTE_LINE_NUMBER_ON_NAME(some_profiler_variable_, __LINE__)

// Defines the containing scope as a profiled region. This allows developers to
// profile their code and see results on their about:profiler page, as well as
// on the UMA dashboard.
#define TRACK_RUN_IN_THIS_SCOPED_REGION(scope_name) \
    ::tracked_objects::ScopedProfile  LINE_BASED_VARIABLE_NAME_FOR_PROFILING(
        FROM_HERE_WITH_EXPLICIT_FUNCTION(#scope_name))


That is, we can delete TRACK_RUN_IN_THIS_SCOPED_REGION_FOR_DEVELOPER_BUILDS,
since it's unused; and we can rename TRACK_RUN_IN_IPC_HANDLER to the more
general name TRACK_RUN_IN_THIS_SCOPED_REGION.

When renaming the macro, it looks like the #include in
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/proxy/dispat...
can just be removed.

[vadimt, 2014/09/25 00:21:21]

Done.

+
 
 namespace tracked_objects {
 class Births;
 
 class BASE_EXPORT ScopedProfile {
  public:
   explicit ScopedProfile(const Location& location);
   ~ScopedProfile();
 
   // Stop tracing prior to the end destruction of the instance.
   void StopClockAndTally();
 
  private:
   Births* birth_;  // Place in code where tracking started.
   TaskStopwatch stopwatch_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedProfile);
 };
 
 }  // namespace tracked_objects
 
 #endif   // BASE_PROFILER_SCOPED_PROFILE_H_