Issue 60013010: Landing https://codereview.chromium.org/40133004 for mnita@google.com.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60013010: Landing https://codereview.chromium.org/40133004 for mnita@google.com. (Closed)

Created:
7 years, 1 month ago by Nebojša Ćirić

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Landing https://codereview.chromium.org/40133004 for mnita@google.com. Implements ES6 String.prototype.normalize method. BUG=v8:2943 TEST=Unit tests for "real life" use cases, edge cases, various types of normalization. TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17532

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+216 lines, -0 lines)			Patch
M	src/i18n.js	View	2 chunks	+39 lines, -0 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	test/intl/string/normalization.js	View	1 chunk	+145 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Nebojša Ćirić

Committed patchset #1 manually as r17532 (presubmit successful).

7 years, 1 month ago (2013-11-06 17:27:39 UTC) #1

Toon Verwaest

7 years, 1 month ago (2013-11-06 18:19:54 UTC) #2

Message was sent while issue was closed.

Got reverted in https://chromiumcodereview.appspot.com/62563002/ due to test
failures.