Implements ES6 String.prototype.normalize method.

Implements ES6 String.prototype.normalize method.

BUG=v8:2943
TEST=Unit tests for "real life" use cases, edge cases, various types of normalization.

[Nebojša Ćirić, 2013-10-24 19:54:18]

https://codereview.chromium.org/40133004/diff/1/src/i18n.js
File src/i18n.js (right):

https://codereview.chromium.org/40133004/diff/1/src/i18n.js#newcode2002
src/i18n.js:2002: * Adds a new method.
Remove * Adds a new method comment. That belongs to CL description.

https://codereview.chromium.org/40133004/diff/1/src/i18n.js#newcode2016
src/i18n.js:2016: var normForm = NORMALIZATION_FORMS.indexOf(form);
normalizationForm, don't abbreviate (except for loop indices).

https://codereview.chromium.org/40133004/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/40133004/diff/1/src/runtime.cc#newcode14069
src/runtime.cc:14069: static const UNormalizationMode normForms[] =
normalizationForms[]

https://codereview.chromium.org/40133004/diff/1/src/runtime.cc#newcode14080
src/runtime.cc:14080: // TODO(mnita) check Normalizer2 (not available in ICU 46)
// TODO(mnita): switch to Normalizer2 when we switch to ICU 51 or above.

https://codereview.chromium.org/40133004/diff/1/src/runtime.cc#newcode14084
src/runtime.cc:14084: if (U_FAILURE(status)) return
isolate->heap()->undefined_value();
if () {
  statement;
}

not

if () statement;

[Nebojša Ćirić, 2013-10-24 21:36:13]

https://codereview.chromium.org/40133004/diff/1/test/intl/string/normalizatio...
File test/intl/string/normalization.js (right):

https://codereview.chromium.org/40133004/diff/1/test/intl/string/normalizatio...
test/intl/string/normalization.js:32: // These are examples of data one might
encounter in real use
End full sentences with .

https://codereview.chromium.org/40133004/diff/1/test/intl/string/normalizatio...
test/intl/string/normalization.js:66: // Make sure we throw RangeError, as the
standard requires
.

[mnita, 2013-10-25 15:22:10]

Implemented all feedback.

https://codereview.chromium.org/40133004/diff/1/src/i18n.js
File src/i18n.js (right):

https://codereview.chromium.org/40133004/diff/1/src/i18n.js#newcode2002
src/i18n.js:2002: * Adds a new method.
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
> Remove * Adds a new method comment. That belongs to CL description.

Done.

https://codereview.chromium.org/40133004/diff/1/src/i18n.js#newcode2016
src/i18n.js:2016: var normForm = NORMALIZATION_FORMS.indexOf(form);
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
> normalizationForm, don't abbreviate (except for loop indices).

Done.

https://codereview.chromium.org/40133004/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/40133004/diff/1/src/runtime.cc#newcode14069
src/runtime.cc:14069: static const UNormalizationMode normForms[] =
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
> normalizationForms[]

Done.

https://codereview.chromium.org/40133004/diff/1/src/runtime.cc#newcode14080
src/runtime.cc:14080: // TODO(mnita) check Normalizer2 (not available in ICU 46)
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
> // TODO(mnita): switch to Normalizer2 when we switch to ICU 51 or above.

Done.

https://codereview.chromium.org/40133004/diff/1/src/runtime.cc#newcode14084
src/runtime.cc:14084: if (U_FAILURE(status)) return
isolate->heap()->undefined_value();
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
> if () {
>   statement;
> }
> 
> not
> 
> if () statement;

Done.

https://codereview.chromium.org/40133004/diff/1/test/intl/string/normalizatio...
File test/intl/string/normalization.js (right):

https://codereview.chromium.org/40133004/diff/1/test/intl/string/normalizatio...
test/intl/string/normalization.js:32: // These are examples of data one might
encounter in real use
On 2013/10/24 21:36:14, Nebojša Ćirić wrote:
> End full sentences with .

Done.

https://codereview.chromium.org/40133004/diff/1/test/intl/string/normalizatio...
test/intl/string/normalization.js:66: // Make sure we throw RangeError, as the
standard requires
On 2013/10/24 21:36:14, Nebojša Ćirić wrote:
> .

Done.

[mnita, 2013-10-25 15:51:59]

Please review this code.
Thank you,
Mihai

[Nebojša Ćirić, 2013-10-25 15:53:18]

lgtm

[Sven Panne, 2013-10-29 07:43:29]

lgtm

[Nebojša Ćirić, 2013-11-06 17:28:26]

On 2013/10/29 07:43:29, Sven Panne wrote:
> lgtm

Commited as https://codereview.chromium.org/60013010 (mnita is not a commiter).