Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 600103002: Changes dip conversions to ceil size and floor origin (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
ananta
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changes dip conversions to ceil size and floor origin This way the size should always remain the same regardless of the origin. Also, it's important that we ceil here otherwise a round trip for DIP to screen to DIP could result in a smaller value resulting in all sorts of wierdness. BUG=417392 TEST=see bug R=ananta@chromium.org Committed: https://crrev.com/e9bc87f33688e6b8f9bdaa71031ad07fb6da086c Cr-Commit-Position: refs/heads/master@{#296559}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M ui/gfx/win/dpi.h View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/gfx/win/dpi.cc View 1 3 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
I wanted to remove these, but they are used in a number of places. I'm ...
6 years, 3 months ago (2014-09-24 19:59:19 UTC) #1
ananta
lgtm
6 years, 3 months ago (2014-09-24 22:04:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600103002/20001
6 years, 3 months ago (2014-09-24 22:09:26 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ebe3380bd6e449463ff6c3972a07dca8f8dd0875
6 years, 3 months ago (2014-09-24 23:32:32 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:46:55 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9bc87f33688e6b8f9bdaa71031ad07fb6da086c
Cr-Commit-Position: refs/heads/master@{#296559}

Powered by Google App Engine
This is Rietveld 408576698