Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: ui/gfx/win/dpi.h

Issue 600103002: Changes dip conversions to ceil size and floor origin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/win/dpi.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/win/dpi.h
diff --git a/ui/gfx/win/dpi.h b/ui/gfx/win/dpi.h
index 9dcf38024562472a38d225119f7f9397905f4592..19f6a579c79e8f9d055127d4797774693aca0336 100644
--- a/ui/gfx/win/dpi.h
+++ b/ui/gfx/win/dpi.h
@@ -22,7 +22,7 @@ GFX_EXPORT void InitDeviceScaleFactor(float scale);
GFX_EXPORT Size GetDPI();
// Gets the scale factor of the display. For example, if the display DPI is
-// 96 then the scale factor is 1.0.
+// 96 then the scale factor is 1.0.
GFX_EXPORT float GetDPIScale();
// Tests to see if the command line flag "--high-dpi-support" is set.
@@ -44,12 +44,14 @@ GFX_EXPORT Point ScreenToDIPPoint(const Point& pixel_point);
GFX_EXPORT Point DIPToScreenPoint(const Point& dip_point);
+// WARNING: there is no right way to scale sizes and rects. The implementation
+// of these strives to maintain a constant size by scaling the size independent
+// of the origin. An alternative is to get the enclosing rect, which is the
+// right way for some situations. Understand which you need before blindly
+// assuming this is the right way.
GFX_EXPORT Rect ScreenToDIPRect(const Rect& pixel_bounds);
-
GFX_EXPORT Rect DIPToScreenRect(const Rect& dip_bounds);
-
GFX_EXPORT Size ScreenToDIPSize(const Size& size_in_pixels);
-
GFX_EXPORT Size DIPToScreenSize(const Size& dip_size);
// Win32's GetSystemMetrics uses pixel measures. This function calls
« no previous file with comments | « no previous file | ui/gfx/win/dpi.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698