AppsGridView: Use specific types instead of views::View*.

ui/app_list/views/apps_grid_view.h

Index: ui/app_list/views/apps_grid_view.h
diff --git a/ui/app_list/views/apps_grid_view.h b/ui/app_list/views/apps_grid_view.h
index fefa9f23d2f437ea80ecaed85e2202af5f5d0ecf..9a39754c75a91e657644b1a9bb64b7291853f7f7 100644
--- a/ui/app_list/views/apps_grid_view.h
+++ b/ui/app_list/views/apps_grid_view.h
@@ -270,7 +270,7 @@ class APP_LIST_EXPORT AppsGridView : public views::View,
   bool IsValidIndex(const Index& index) const;
 
   Index GetIndexOfView(const views::View* view) const;
-  views::View* GetViewAtIndex(const Index& index) const;
+  AppListItemView* GetViewAtIndex(const Index& index) const;

[calamity, 2014/09/26 01:47:26]

This should have a comment mentioning that these methods are only for
AppListItemViews (as opposed to PulsingBlockViews).

[Matt Giuca, 2014/09/26 03:48:39]

If GetIndexOfView is only supposed to be passed an AppListItemView, then I can
just change its argument type to AppListItemView*. (Then don't need a comment.)

(I'd rather type safety than comments.) 

 
   // Gets the index of the AppListItemView at the end of the view model.
   Index GetLastViewIndex() const;
@@ -332,15 +332,16 @@ class APP_LIST_EXPORT AppsGridView : public views::View,
   // Updates |model_| to move item represented by |item_view| into a folder
   // containing item located at |target| slot, also update |view_model_| for
   // the related view changes.
-  void MoveItemToFolder(views::View* item_view, const Index& target);
+  void MoveItemToFolder(AppListItemView* item_view, const Index& target);
 
   // Updates both data model and view_model_ for re-parenting a folder item to a
   // new position in top level item list.
-  void ReparentItemForReorder(views::View* item_view, const Index& target);
+  void ReparentItemForReorder(AppListItemView* item_view, const Index& target);
 
   // Updates both data model and view_model_ for re-parenting a folder item
   // to anther folder target.
-  void ReparentItemToAnotherFolder(views::View* item_view, const Index& target);
+  void ReparentItemToAnotherFolder(AppListItemView* item_view,
+                                   const Index& target);
 
   // If there is only 1 item left in the source folder after reparenting an item
   // from it, updates both data model and view_model_ for removing last item
@@ -414,7 +415,7 @@ class APP_LIST_EXPORT AppsGridView : public views::View,
 
   // Gets the item view located at |slot| on the current page. If there is
   // no item located at |slot|, returns NULL.
-  views::View* GetViewAtSlotOnCurrentPage(int slot);
+  AppListItemView* GetViewAtSlotOnCurrentPage(int slot);
 
   // Sets state of the view with |target_index| to |is_target_folder| for
   // dropping |drag_view_|.
@@ -474,7 +475,7 @@ class APP_LIST_EXPORT AppsGridView : public views::View,
   int cols_;
   int rows_per_page_;
 
-  // Tracks app item views. There is a view per item in |model_|.
+  // List of AppListItemViews. There is a view per item in |model_|.
   views::ViewModel view_model_;
 
   // Tracks pulsing block views.