AppsGridView: Use specific types instead of views::View*.

ui/app_list/views/apps_grid_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_APP_LIST_VIEWS_APPS_GRID_VIEW_H_
 #define UI_APP_LIST_VIEWS_APPS_GRID_VIEW_H_
 
 #include <set>
 #include <string>
 
@@ skipping 252 matching lines @@
   // Convert between the model index and the visual index. The model index
   // is the index of the item in AppListModel. The visual index is the Index
   // struct above with page/slot info of where to display the item.
   Index GetIndexFromModelIndex(int model_index) const;
   int GetModelIndexFromIndex(const Index& index) const;
 
   void SetSelectedItemByIndex(const Index& index);
   bool IsValidIndex(const Index& index) const;
 
   Index GetIndexOfView(const views::View* view) const;
-  views::View* GetViewAtIndex(const Index& index) const;
+  AppListItemView* GetViewAtIndex(const Index& index) const;

[calamity, 2014/09/26 01:47:26]

This should have a comment mentioning that these methods are only for
AppListItemViews (as opposed to PulsingBlockViews).

[Matt Giuca, 2014/09/26 03:48:39]

If GetIndexOfView is only supposed to be passed an AppListItemView, then I can
just change its argument type to AppListItemView*. (Then don't need a comment.)

(I'd rather type safety than comments.) 

 
   // Gets the index of the AppListItemView at the end of the view model.
   Index GetLastViewIndex() const;
 
   void MoveSelected(int page_delta, int slot_x_delta, int slot_y_delta);
 
   void CalculateIdealBounds();
   void AnimateToIdealBounds();
 
   // Invoked when the given |view|'s current bounds and target bounds are on
@@ skipping 41 matching lines @@
 
   // Invoked when |page_flip_timer_| fires.
   void OnPageFlipTimer();
 
   // Updates |model_| to move item represented by |item_view| to |target| slot.
   void MoveItemInModel(views::View* item_view, const Index& target);
 
   // Updates |model_| to move item represented by |item_view| into a folder
   // containing item located at |target| slot, also update |view_model_| for
   // the related view changes.
-  void MoveItemToFolder(views::View* item_view, const Index& target);
+  void MoveItemToFolder(AppListItemView* item_view, const Index& target);
 
   // Updates both data model and view_model_ for re-parenting a folder item to a
   // new position in top level item list.
-  void ReparentItemForReorder(views::View* item_view, const Index& target);
+  void ReparentItemForReorder(AppListItemView* item_view, const Index& target);
 
   // Updates both data model and view_model_ for re-parenting a folder item
   // to anther folder target.
-  void ReparentItemToAnotherFolder(views::View* item_view, const Index& target);
+  void ReparentItemToAnotherFolder(AppListItemView* item_view,
+                                   const Index& target);
 
   // If there is only 1 item left in the source folder after reparenting an item
   // from it, updates both data model and view_model_ for removing last item
   // from the source folder and removes the source folder.
   void RemoveLastItemFromReparentItemFolderIfNecessary(
       const std::string& source_folder_id);
 
   // If user does not drop the re-parenting folder item to any valid target,
   // cancel the re-parenting action, let the item go back to its original
   // parent folder with UI animation.
@@ skipping 53 matching lines @@
   Index GetNearestTileIndexForPoint(const gfx::Point& point) const;
 
   // Gets the bounds of the tile located at |slot| on the current page.
   gfx::Rect GetExpectedTileBounds(int slot) const;
 
   // Gets the bounds of the tile located at |row| and |col| on the current page.
   gfx::Rect GetExpectedTileBounds(int row, int col) const;
 
   // Gets the item view located at |slot| on the current page. If there is
   // no item located at |slot|, returns NULL.
-  views::View* GetViewAtSlotOnCurrentPage(int slot);
+  AppListItemView* GetViewAtSlotOnCurrentPage(int slot);
 
   // Sets state of the view with |target_index| to |is_target_folder| for
   // dropping |drag_view_|.
   void SetAsFolderDroppingTarget(const Index& target_index,
                                  bool is_target_folder);
 
   // Invoked when |reorder_timer_| fires to show re-order preview UI.
   void OnReorderTimer();
 
   // Invoked when |folder_item_reparent_timer_| fires.
@@ skipping 39 matching lines @@
   AppsGridViewFolderDelegate* folder_delegate_;
 
   PaginationModel pagination_model_;
   // Must appear after |pagination_model_|.
   scoped_ptr<PaginationController> pagination_controller_;
   PageSwitcher* page_switcher_view_;  // Owned by views hierarchy.
 
   int cols_;
   int rows_per_page_;
 
-  // Tracks app item views. There is a view per item in |model_|.
+  // List of AppListItemViews. There is a view per item in |model_|.
   views::ViewModel view_model_;
 
   // Tracks pulsing block views.
   views::ViewModel pulsing_blocks_model_;
 
   views::View* selected_view_;
 
   AppListItemView* drag_view_;
 
   // The index of the drag_view_ when the drag starts.
@@ skipping 76 matching lines @@
 
   // True if the drag_view_ item is a folder item being dragged for reparenting.
   bool dragging_for_reparent_item_;
 
   DISALLOW_COPY_AND_ASSIGN(AppsGridView);
 };
 
 }  // namespace app_list
 
 #endif  // UI_APP_LIST_VIEWS_APPS_GRID_VIEW_H_