Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 59983004: Fixes for blurroundrect gm/bench. (Closed)

Created:
7 years, 1 month ago by scroggo
Modified:
7 years, 1 month ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fixes for blurroundrect gm/bench. Simplify naming/various cases. Have an atlas of gms, rather than several different images. In the bench, pull non rendering out of the loop. Use meaningful enums instead of integers where appropriate. Add comments. Addresses comments in https://codereview.chromium.org/52793005/ R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=12144

Patch Set 1 #

Patch Set 2 : Add scale #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -191 lines) Patch
M bench/BlurRoundRectBench.cpp View 2 chunks +49 lines, -64 lines 1 comment Download
M gm/blurroundrect.cpp View 1 3 chunks +64 lines, -127 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
7 years, 1 month ago (2013-11-05 20:46:14 UTC) #1
robertphillips
lgtm + nit https://codereview.chromium.org/59983004/diff/30001/bench/BlurRoundRectBench.cpp File bench/BlurRoundRectBench.cpp (right): https://codereview.chromium.org/59983004/diff/30001/bench/BlurRoundRectBench.cpp#newcode90 bench/BlurRoundRectBench.cpp:90: DEF_BENCH(return new BlurRoundRectBench(100, 100, 6);) Fix ...
7 years, 1 month ago (2013-11-05 21:07:04 UTC) #2
scroggo
7 years, 1 month ago (2013-11-05 21:11:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r12144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698