Don't re-focus Settings window when opening IME options

chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

Index: chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
index 561670b2de7f58e530775194858a44f82a0fcfd7..78a278cde8540499d6b64d186de6c7c482072f5f 100644
--- a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
@@ -243,10 +243,6 @@ void CrosLanguageOptionsHandler::InputMethodOptionsOpenCallback(
       ui::PAGE_TRANSITION_LINK,
       false);
   browser->OpenURL(params);

[stevenjb, 2014/09/24 16:12:53]

nit: It looks to me like this will allways be an extension settings URL,
correct?
We might want to add a TODO here to use a special helper method for opening
extension settings pages so that if/when we change how we do that this will do
the right thing. We should include 'chrome-extension:' in the comment so that a
grep will find it.
+kalman@ just FYI

Also, does removing these lines affect the behavior on non-chromeos (i.e.
settings in a tab)? They seem unnecessary, and this should definitely be handled
in OpenURL(), not here, but we should confirm that.

[michaelpg, 2014/09/24 21:23:06]

I think so but I'm not positive.
Probably a good idea. I will let kalman@ or shuchen@ decide whether to do so and
whom to assign the TODO to just so I can commit this before the branch happens.
This is Chrome OS-only. Like it literally doesn't compile on other platforms,
right?

[stevenjb, 2014/09/25 15:49:41]

Ah, yes, you're correct, I didn't notice this was
cros_language_options_handler.cc and not just language_options_handler.cc.
Confusing.

-  browser->window()->Show();
-  content::WebContents* web_contents =
-      browser->tab_strip_model()->GetActiveWebContents();
-  web_contents->GetDelegate()->ActivateContents(web_contents);
 }
 
 void CrosLanguageOptionsHandler::AddImeProvider(base::ListValue* list) {