Don't re-focus Settings window when opening IME options

chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 224 matching lines @@
   if (!ime)
     return;
 
   Browser* browser = chrome::FindBrowserWithWebContents(
       web_ui()->GetWebContents());
   content::OpenURLParams params(ime->options_page_url(),
       content::Referrer(),
       SINGLETON_TAB,
       ui::PAGE_TRANSITION_LINK,
       false);
   browser->OpenURL(params);

[stevenjb, 2014/09/24 16:12:53]

nit: It looks to me like this will allways be an extension settings URL,
correct?
We might want to add a TODO here to use a special helper method for opening
extension settings pages so that if/when we change how we do that this will do
the right thing. We should include 'chrome-extension:' in the comment so that a
grep will find it.
+kalman@ just FYI

Also, does removing these lines affect the behavior on non-chromeos (i.e.
settings in a tab)? They seem unnecessary, and this should definitely be handled
in OpenURL(), not here, but we should confirm that.

[michaelpg, 2014/09/24 21:23:06]

I think so but I'm not positive.
Probably a good idea. I will let kalman@ or shuchen@ decide whether to do so and
whom to assign the TODO to just so I can commit this before the branch happens.
This is Chrome OS-only. Like it literally doesn't compile on other platforms,
right?

[stevenjb, 2014/09/25 15:49:41]

Ah, yes, you're correct, I didn't notice this was
cros_language_options_handler.cc and not just language_options_handler.cc.
Confusing.

-  browser->window()->Show();
-  content::WebContents* web_contents =
-      browser->tab_strip_model()->GetActiveWebContents();
-  web_contents->GetDelegate()->ActivateContents(web_contents);
 }
 
 void CrosLanguageOptionsHandler::AddImeProvider(base::ListValue* list) {
   Profile* profile = Profile::FromWebUI(web_ui());
   const extensions::ExtensionSet& enabled_extensions =
       extensions::ExtensionRegistry::Get(profile)->enabled_extensions();
   for (size_t i = 0; i < list->GetSize(); ++i) {
     base::DictionaryValue* entry;
     list->GetDictionary(i, &entry);
 
     std::string input_method_id;
     entry->GetString("id", &input_method_id);
 
     std::string extension_id =
         extension_ime_util::GetExtensionIDFromInputMethodID(input_method_id);
     const extensions::Extension* extension =
         enabled_extensions.GetByID(extension_id);
     if (extension)
       entry->SetString("extensionName", extension->name());
   }
 }
 
 }  // namespace options
 }  // namespace chromeos